Skip to content

[Unity] Cutlass kernel compatibility with cmake 3.18+ #16302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[Unity] Cutlass kernel compatibility with cmake 3.18+ #16302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc4f0f7
[Unity] Cutlass kernel compatibility with cmake 3.18+
Lunderberg Dec 29, 2023
d82694f
Merge branch 'unity' into unity_cmake_compatibility_fix_pr_16302
Lunderberg Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions cmake/modules/CUDA.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,28 @@ if(USE_CUDA)
list(APPEND TVM_RUNTIME_LINKER_LIBS ${CUDA_CUDA_LIBRARY})
list(APPEND TVM_RUNTIME_LINKER_LIBS ${CUDA_NVRTC_LIBRARY})

# Compatibility with cmake 3.18+
#
# The updates to the cutlass kernels made in TVM PR#16244 require
# symbols provided in cuda 7.5+. While the cuda architecture is
# specified by setting `NVCC_FLAGS` in the `CMakeLists.txt` for each
# kernel, cmake 3.18+ also sets it based on the
# `CMAKE_CUDA_ARCHITECTURES` value. If not set, cmake will explicitly
# pass the compute capability as nvidia's default of 5.2, *EVEN IF* it
# has already been specified in `NVCC_FLAGS`. Because the kernels
# cannot compile with compute capability of 5.2, this causes
# compilation errors.
#
# By setting `CMAKE_CUDA_ARCHITECTURES` to `OFF`, cmake does not add
# 5.2 as a target architecture.
#
# See https://cmake.org/cmake/help/latest/policy/CMP0104.html for
# details on CMake's policy for CUDA architecture flags.
#
# See https://cmake.org/cmake/help/latest/policy/CMP0104.html for the
# default CUDA architecture for each version of CUDA.
set(CMAKE_CUDA_ARCHITECTURES OFF)

if(USE_CUDNN)
message(STATUS "Build with cuDNN support")
include_directories(SYSTEM ${CUDA_CUDNN_INCLUDE_DIRS})
Expand Down