[Runtime] Use cudaGetDeviceCount to check if device exists #16377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `cudaDeviceGetAttribute` will set the global error code when the device doesn't exist and will impact subsequent CUDA API calls.
tqchen
approved these changes
Jan 10, 2024
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Apr 18, 2024
This commit resolves a bug that was introduced in apache#16377. If no CUDA-capable GPUs are present, the call to `cudaGetDeviceCount` will return an error, which will be raised as an exception by the `CUDA_CALL` macro. However, checking the `kExist` flag is valid even if no GPUs are present. This commit removes the use of `CUDA_CALL`, and instead returns false in this case.
tqchen
pushed a commit
that referenced
this pull request
Apr 18, 2024
…6903) This commit resolves a bug that was introduced in #16377. If no CUDA-capable GPUs are present, the call to `cudaGetDeviceCount` will return an error, which will be raised as an exception by the `CUDA_CALL` macro. However, checking the `kExist` flag is valid even if no GPUs are present. This commit removes the use of `CUDA_CALL`, and instead returns false in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
cudaDeviceGetAttributewill set the global error code when the device doesn't exist and will impact subsequent CUDA API calls.cc @tqchen @junrushao