Skip to content

Conversation

@Hzfengsy
Copy link
Member

@Hzfengsy Hzfengsy commented Feb 5, 2024

Thanks @liushengjiezj for pointing out the bug and initial fix. This PR fixes the broken test and make CI green again

cc @tqchen @Johnson9009

@Hzfengsy Hzfengsy force-pushed the fix_tir_ci branch 2 times, most recently from 71e6c2c to 30cd083 Compare February 5, 2024 12:40
@Johnson9009
Copy link
Contributor

Thanks for the quick fix, LGTM.

@Johnson9009
Copy link
Contributor

It seems we haven't fixed all the failed cases, some cases are crashed and haven't been caught by CI (#16632 ). We have done some investigations and have some found, I will record them in #16633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants