[TIR] Expand debug symbol output for CodeGenLLVM #16544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `CodeGenLLVM` would include DWARF symbols specifying the function signature of each TIR function. This commit expands the information exposed in the debug symbols. * Name functions based on the name of the corresponding TIR function. This is taken either from the `attr::kGlobalSymbol` if present, or the PrimFunc's `GlobalVar` otherwise. * Name function parameter based on their TIR variable name. * Annotate the name, the type signature, and parameter names for the private function produced by the `tir::attr::compute_scope` attribute. * Name local variables based on the name and type of the corresponding TIR variable.
Contributor
Author
|
This came about while debugging the implementation of #16542, but is otherwise unrelated. |
Not available on CI version of llvm
Contributor
Author
|
Merged from main to PR branch, to resolve CI breakage that was fixed in #16546. |
slyubomirsky
approved these changes
Feb 22, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
I'm all for propagating more debug information and I don't see anything to take issue with here.
PhilippvK
pushed a commit
to PhilippvK/tvm
that referenced
this pull request
Jun 4, 2024
* [TIR] Expand debug symbol output for CodeGenLLVM Prior to this commit, the `CodeGenLLVM` would include DWARF symbols specifying the function signature of each TIR function. This commit expands the information exposed in the debug symbols. * Name functions based on the name of the corresponding TIR function. This is taken either from the `attr::kGlobalSymbol` if present, or the PrimFunc's `GlobalVar` otherwise. * Name function parameter based on their TIR variable name. * Annotate the name, the type signature, and parameter names for the private function produced by the `tir::attr::compute_scope` attribute. * Name local variables based on the name and type of the corresponding TIR variable. * lint fixes * lint fixes * Remove reference to llvm::dwarf::DWARF_VERSION Not available on CI version of llvm * Update number of debug locations * Fix segfault for pointers to custom data types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
CodeGenLLVMwould include DWARF symbols specifying the function signature of each TIR function. This commit expands the information exposed in the debug symbols.Name functions based on the name of the corresponding TIR function. This is taken either from the
attr::kGlobalSymbolif present, or the PrimFunc'sGlobalVarotherwise.Name function parameter based on their TIR variable name.
Annotate the name, the type signature, and parameter names for the private function produced by the
tir::attr::compute_scopeattribute.Name local variables based on the name and type of the corresponding TIR variable.