Skip to content

Conversation

@Lunderberg
Copy link
Contributor

This commit updates the cutlass annotator to check if relax.Function.attrs is None before attempting to access it.

This commit updates the cutlass annotator to check if
`relax.Function.attrs` is `None` before attempting to access it.
@Lunderberg
Copy link
Contributor Author

Unfortunately, I was unable to make a standalone unit test that would trigger this bug. For the long term, I plan to change the default of relax.Function.attrs from None to an empty dictionary. As it is, having None as the function attributes and having {} as the function attributes are semantically equivalent, but require an extra check at each usage.

@masahi masahi merged commit 2ca8f31 into apache:main Feb 23, 2024
@Lunderberg Lunderberg deleted the cutlass_check_for_none_function_attrs branch February 23, 2024 23:15
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Mar 12, 2024
This commit updates the cutlass annotator to check if
`relax.Function.attrs` is `None` before attempting to access it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants