[CLML] Fix build TVM with CLML on MacOS #16672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tvm-bot rerun |
The first fix related to the problem when we build TVM with `USE_CLML` option and OpenCL header files were not found in the system. The second fix is for building CLML graph executor in Android build. `find_library` on MacOS is looking for libraries with `dylib` extension. This is why OpenCL libraries from CLML SDK were not found. To fix this problem we specify paths to the libraries manually in case if they were not found by `find_library`.
echuraev
force-pushed
the
echuraev/fix_clml_build_on_macos
branch
from
56ac4bd to
5623f01
Compare
Contributor
Author
|
@srkreddy1238 CI is green. Could you please review this PR? |
tqchen
approved these changes
Mar 19, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
The first fix related to the problem when we build TVM with `USE_CLML` option and OpenCL header files were not found in the system. The second fix is for building CLML graph executor in Android build. `find_library` on MacOS is looking for libraries with `dylib` extension. This is why OpenCL libraries from CLML SDK were not found. To fix this problem we specify paths to the libraries manually in case if they were not found by `find_library`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix related to the problem when we build TVM with
USE_CLMLoption and OpenCL header files were not found in the system. The second fix is for building CLML graph executor in Android build.find_libraryon MacOS is looking for libraries withdylibextension. This is why OpenCL libraries from CLML SDK were not found. To fix this problem we specify paths to the libraries manually in case if they were not found byfind_library.cc: @srkreddy1238