[SLM] Provide consistent dynamic shape when specified as python string #16781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve a breakage introduced in apache#16757. Prior to apache#16757, distinct TIR variables were unified if they had the same name. This commit avoids using distinct TIR variables to represent the same user input.
Lunderberg
changed the title
If there is a trivial binding of `Var = DataflowVar`, but the non-dataflow variable is never used outside the dataflow block in which is is declared, then we should keep the name of the upstream `DataflowVar`, as it is more likely to be the human-readable name (e.g. a function parameter).
Expand handling of python strings to reproduce pre-16757 behavior If a dynamic shape is specified with a python string, all instances of that python string within a given function should be represented by the same TIR variable.
Lunderberg
force-pushed
the
slm_consistent_nn_linear_out_features
branch
from
e32aa2e to
3043702
Compare
Contributor
Author
|
This PR is superseded by #16785. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a breakage introduced in #16757. Prior to #16757, distinct TIR variables were unified if they had the same name. This commit avoids using distinct TIR variables to represent the same user input.