[Debug] Improve error messages in LiftTransformParams #16802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LiftTransformParams` pass requires Relax functions that have the `attr::kNumInput` attribute (`"num_input"`). By default, it collects and applies only to functions with this attribute. If the user specifies functions that don't match this criteria, the `LiftTransformParams` will raise an error. This commit improves the error messages that are raised when the specified function is missing, is not an IRModule, or is missing the `kNumInput` attribute. Previously the error messages were raised implicitly by `IRModule::Lookup`, `Downcast<Function>`, or `Optional::value`, respectively.
vinx13
approved these changes
Mar 27, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
The `LiftTransformParams` pass requires Relax functions that have the `attr::kNumInput` attribute (`"num_input"`). By default, it collects and applies only to functions with this attribute. If the user specifies functions that don't match this criteria, the `LiftTransformParams` will raise an error. This commit improves the error messages that are raised when the specified function is missing, is not an IRModule, or is missing the `kNumInput` attribute. Previously the error messages were raised implicitly by `IRModule::Lookup`, `Downcast<Function>`, or `Optional::value`, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LiftTransformParamspass requires Relax functions that have theattr::kNumInputattribute ("num_input"). By default, it collects and applies only to functions with this attribute. If the user specifies functions that don't match this criteria, theLiftTransformParamswill raise an error.This commit improves the error messages that are raised when the specified function is missing, is not an IRModule, or is missing the
kNumInputattribute. Previously the error messages were raised implicitly byIRModule::Lookup,Downcast<Function>, orOptional::value, respectively.