Skip to content

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Mar 29, 2024

cc @tqchen

@github-actions github-actions bot requested a review from tqchen March 29, 2024 00:14
template <>
struct hash<tvm::runtime::relax_vm::CUDAGraphCaptureKey> {
size_t operator()(const tvm::runtime::relax_vm::CUDAGraphCaptureKey& key) const {
std::hash<int64_t> hash_fn;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

bool IsStatic(const StructInfo& sinfo, std::vector<const VarNode*>* vars_collector = nullptr,
std::vector<const tir::VarNode*>* tir_vars_collector = nullptr) {
Copy link
Member

@tqchen tqchen Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(refactor nit, no need in this PR) consider use tir::Var ith reference instead to avoid var de-allocation during rewrite

@tqchen
Copy link
Member

tqchen commented Mar 30, 2024

@tvm-bot rerun

@vinx13 vinx13 merged commit ef32a61 into apache:main Mar 30, 2024
thaisacs pushed a commit to thaisacs/tvm that referenced this pull request Apr 3, 2024
* [Relax] Enable capturing symbolic shapes in cuda graph

* Add Bind sinfo util

* Bind ret sinfo

* address comments

* add comments

* fix

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants