-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Relax] Enable capturing symbolic shapes in cuda graph #16815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Mar 29, 2024
tqchen
requested changes
Mar 29, 2024
| template <> | ||
| struct hash<tvm::runtime::relax_vm::CUDAGraphCaptureKey> { | ||
| size_t operator()(const tvm::runtime::relax_vm::CUDAGraphCaptureKey& key) const { | ||
| std::hash<int64_t> hash_fn; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tqchen
reviewed
Mar 29, 2024
| } | ||
|
|
||
| bool IsStatic(const StructInfo& sinfo, std::vector<const VarNode*>* vars_collector = nullptr, | ||
| std::vector<const tir::VarNode*>* tir_vars_collector = nullptr) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(refactor nit, no need in this PR) consider use tir::Var ith reference instead to avoid var de-allocation during rewrite
tqchen
reviewed
Mar 29, 2024
tqchen
reviewed
Mar 29, 2024
tqchen
approved these changes
Mar 29, 2024
tqchen
approved these changes
Mar 29, 2024
Member
|
@tvm-bot rerun |
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
* [Relax] Enable capturing symbolic shapes in cuda graph * Add Bind sinfo util * Bind ret sinfo * address comments * add comments * fix * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tqchen