Skip to content

Overriding the StructuralEqual() for easy usage #16908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Overriding the StructuralEqual() for easy usage #16908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
874fbd7
Overriding the Structural Equal() for easy usage
sdalvi-quic Apr 20, 2024
c01b402
lint error fixed
sdalvi-quic Apr 23, 2024
a3bb914
fixing white space lint error
sdalvi-quic Apr 24, 2024
b9b452b
whitespace lint error
sdalvi-quic Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/tvm/node/structural_equal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ class StructuralEqual : public BaseValueEqual {
* \brief Compare objects via strutural equal.
* \param lhs The left operand.
* \param rhs The right operand.
* \param map_free_params Whether or not to map free variables.
* \return The comparison result.
*/
TVM_DLL bool operator()(const ObjectRef& lhs, const ObjectRef& rhs) const;
TVM_DLL bool operator()(const ObjectRef& lhs, const ObjectRef& rhs,
const bool map_free_params = false) const;
};

/*!
Expand Down
5 changes: 3 additions & 2 deletions src/node/structural_equal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,9 @@ TVM_REGISTER_GLOBAL("node.GetFirstStructuralMismatch")
return first_mismatch;
});

bool StructuralEqual::operator()(const ObjectRef& lhs, const ObjectRef& rhs) const {
return SEqualHandlerDefault(false, nullptr, false).Equal(lhs, rhs, false);
bool StructuralEqual::operator()(const ObjectRef& lhs, const ObjectRef& rhs,
bool map_free_params) const {
return SEqualHandlerDefault(false, nullptr, false).Equal(lhs, rhs, map_free_params);
}

bool NDArrayEqual(const runtime::NDArray::Container* lhs, const runtime::NDArray::Container* rhs,
Expand Down