[Relax] Refactor RealizeVDevice to remove in-place mutation #17213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `relax.transform.RealizeVDevice` pass performed in-place update on expressions appearing in its input `IRModule`, overwriting their struct info. In-place mutation of TVM's IR types is only legal when the scope has sole ownership of the IR object, such as through the `CopyOnWrite` functionality, and is not allowed when the object is shared. As a result, applying `RealizeVDevice` would cause unexpected updates in unrelated expressions. Most noticeably, the `IRModule` used as input to `RealizeVDevice` would have its variable erroneously updated. This commit refactors the `RealizeVDevice` transform to remove all in-place mutation. The same propagation rules are followed, with known `VDevice` annotations propagated forward from the output of `R.hint_on_device`, and propagated backwards from the input of `R.hint_on_device` if no such annotation already exists. Closes apache#17205.
tqchen
approved these changes
Sep 7, 2024
Lunderberg
deleted the
refactor_realize_vdevice_to_remove_in_place_mutation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax.transform.RealizeVDevicepass performed in-place update on expressions appearing in its inputIRModule, overwriting their struct info. In-place mutation of TVM's IR types is only legal when the scope has sole ownership of the IR object, such as through theCopyOnWritefunctionality, and is not allowed when the object is shared. As a result, applyingRealizeVDevicewould cause unexpected updates in unrelated expressions. Most noticeably, theIRModuleused as input toRealizeVDevicewould have its variable erroneously updated.This commit refactors the
RealizeVDevicetransform to remove all in-place mutation. The same propagation rules are followed, with knownVDeviceannotations propagated forward from the output ofR.hint_on_device, and propagated backwards from the input ofR.hint_on_deviceif no such annotation already exists.Closes #17205.