[Relax] Allow ingesting Upsample module from torch.export either using Size or Scale Factor argument #17721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugolatendresse
changed the title
MasterJH5574
approved these changes
Mar 10, 2025
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
LGTM, thank you @hugolatendresse!
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…g Size or Scale Factor argument (apache#17721) Torch's Upsample module can only accomodate the Size or Scale Factor argument but not both. Regarding that limitation, there was previously a bug regarding the parsing of the arguments (the wrong order of arguments was assume). This PR fixes that and adds a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch's Upsample module can only accomodate the Size or Scale Factor argument but not both. Regarding that limitation, there was previously a bug regarding the parsing of the arguments (the wrong order of arguments was assume). This PR fixes that and adds a unit test
cc: @MasterJH5574