Skip to content

[Relax] Fix Torch frontends to report all the missing ops #17826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025
+24 −6
Merged

[Relax] Fix Torch frontends to report all the missing ops #17826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1aed53
enhance missing func types finding in exported program and fx graph f…
Apr 11, 2025
bd55d15
fix trailing space issue
Apr 11, 2025
d4476b5
fix lint issues by formatting the code
Apr 11, 2025
7f300b3
fix name error in fx frontend
Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions python/tvm/relax/frontend/torch/exported_program_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,18 @@ def from_exported_program(
):
output = None
with self.block_builder.dataflow():

# Find all the missing function types
missing_func_types = list(
{
node.target.__name__
for node in nodes
if node.op == "call_function"
and node.target.__name__ not in self.convert_map
}
)
assert not missing_func_types, f"Unsupported function types {missing_func_types}"

# Translate the model.
for node in nodes:
if node.op == "placeholder":
Expand All @@ -537,9 +549,6 @@ def from_exported_program(
self.env[node] = getattr(exported_program.graph_module, node.target)
elif node.op == "call_function":
func_name = node.target.__name__
assert (
func_name in self.convert_map
), f"Unsupported function type {func_name}"
self.env[node] = self.convert_map[func_name](node)
else:
raise ValueError(f"Unsupported op {node.op}")
Expand Down
15 changes: 12 additions & 3 deletions python/tvm/relax/frontend/torch/fx_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,18 @@ def from_fx(
with self.block_builder.function(name=func_name, params=inputs.copy(), attrs=func_attrs):
output = None
with self.block_builder.dataflow():

# Find all the missing function types
missing_func_types = list(
{
node.target.__name__
for node in graph.nodes
if node.op == "call_function"
and node.target.__name__ not in self.convert_map
}
)
assert not missing_func_types, f"Unsupported function types {missing_func_types}"

# Translate model parameters.
for _, param in model.named_parameters():
shape = param.data.shape
Expand Down Expand Up @@ -929,9 +941,6 @@ def from_fx(
self.env[node] = self.convert_map[type(module)](node)
elif node.op == "call_function":
func_name = node.target.__name__
assert (
func_name in self.convert_map
), f"Unsupported function type {func_name}"
if func_name in custom_ops:
self.env[node] = self.convert_map[func_name](node, self)
else:
Expand Down
Loading