-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Build] Migrate Python packaging to pyproject.toml with scikit-build-core #18239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @tqchen |
|
also cc @MasterJH5574 , would be great to test the wheel for specifically cuda related usecases like cutlass(maybe we need to also update mlc), |
Sure. Happy to test when this PR gets ready. |
tqchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one final comment, please cross check locally
|
@tlopex @MasterJH5574 please help cross check once ready |
|
cc @MasterJH5574 |
Great, I'll find a time in the next few days. BTW there is a windows CI error that we need to fix. |
How could we fix it? Just by committing again to restart CI? |
|
windows should be fixed already by #18245. we don't need to be gree to merge We consider should followup and change the conda based windows ci to use the pip wheel based now that we have the scikit-build-core |
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following #18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
Following apache#18239, this PR fixes a few issues we ran into during testing the packaging flow through scikit-build-core.
This pr migrates the TVM Python packaging system from the setup.py flow to the modern, PEP 517/518 compliant pyproject.toml standard, which allows us to produce a single, Python-version-agnostic wheel.
This change streamlines the process for both developers and users.
For local development, you can now set up a fully-functional editable environment with a single command:
pip install -e ..To create the distributable package for release, simply run
pip wheel -w dist ., which will produce a universal wheel in the dist/ folder. This ensures that end-users can reliably install TVM with a standard pip install tvm, regardless of their specific Python 3 version.