-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Relax][Frontend][Torch] Fix parsing error when input dimension of unbind is 1 #18351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @eaten-cake, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific parsing error within the TVM Relax frontend for Torch, which occurred when processing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a parsing error in the PyTorch frontend for the unbind operator when the input dimension size is 1. The fix correctly handles this edge case by using squeeze directly, avoiding an incorrect split operation. A regression test is added to cover this specific scenario. The changes are correct and well-tested. I have one suggestion to improve the readability of the newly added test case.
65787c9 to
33db3dc
Compare
|
resolve #18338 |
tlopex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @eaten-cake
fix issue #18338
When the input dimension of unbind is 1, we should directly apply squeeze instead of performing split followed by squeeze. This issue has been fixed, and a corresponding regression test has been added.
Previously, the error occurred because when the output of split contains only a single tensor, the
struct_infoof the expression isTensorStructInforather thanTupleStructInfo. As a result, theTupleGetItemnode generated attvm/python/tvm/relax/frontend/torch/base_fx_graph_translator.py
Lines 1279 to 1280 in f68651f