Register shape functions for some image related ops #6373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurawly
changed the title
icemelon
reviewed
Sep 25, 2020
| out = output_tensor((4,), "int64") | ||
| out[0] = int64(data[0]) | ||
| out[1] = int64(2) | ||
| out[2] = int64(target_shape[0]) |
Member
There was a problem hiding this comment.
do we support different layout for affine_grid?
Contributor
Author
There was a problem hiding this comment.
No I don't think so.
| out[0] = int64(data[0]) | ||
| out[1] = int64(data[1]) | ||
| out[2] = int64(grid[2]) | ||
| out[3] = int64(grid[3]) |
Member
There was a problem hiding this comment.
same question here. different layout?
Contributor
Author
There was a problem hiding this comment.
No, I think it only supports NCHW
Member
|
ping @Laurawly @icemelon9 please follow up |
icemelon
approved these changes
Oct 28, 2020
Member
icemelon
left a comment
icemelon
left a comment
There was a problem hiding this comment.
LGTM. Please resolve the conflict
zhiics
reviewed
Oct 28, 2020
tests/python/relay/test_any.py
Outdated
| y = relay.image.resize(data, size, layout) | ||
| mod["main"] = relay.Function([data], y) | ||
| data_np = np.random.uniform(size=static_data_shape).astype(dtype) | ||
| for kind in ["debug", "vm"]: |
Member
There was a problem hiding this comment.
BTW, this has been moved to test_result and you may want to annotate the test with @tvm.testing.uses_gpu if gpu is supported
Laurawly
force-pushed
the
shape_func
branch
2 times, most recently
from
6a6fda5 to
4441338
Compare
zhiics
approved these changes
Nov 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* debugging * added three shape funcs * fix lint * address comment * resolve conflicts * resolve conflicts * resolve conflicts * resolve conflicts * resolve conflicts
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* debugging * added three shape funcs * fix lint * address comment * resolve conflicts * resolve conflicts * resolve conflicts * resolve conflicts * resolve conflicts
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* debugging * added three shape funcs * fix lint * address comment * resolve conflicts * resolve conflicts * resolve conflicts * resolve conflicts * resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shape functions for image.resize, image.grid_sample and image.affine_grid
@icemelon9 Could you please review?