[TVMC] rename composite target "acl" #7508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renames the "acl" composite target to point to the specific library it represents
mbaret
approved these changes
Feb 24, 2021
Contributor
mbaret
left a comment
mbaret
left a comment
There was a problem hiding this comment.
Looks uncontroversial to me. We'll probably want to follow up later to rename arm_compute_lib -> compute_library elsewhere.
Contributor
|
I googled "compute library" and the first 2-3 results are for ACL so I think it's fine to change the composite target name. |
Contributor
Author
I'll check whether there is any reason to change in other places, and follow-up if needed, with proper justification. For now we can leave it as is. |
Contributor
Author
Contributor
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Renames the "acl" composite target to point to the specific library it represents
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Renames the "acl" composite target to point to the specific library it represents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TVMC, renames the
aclcomposite target to point to the specific library it represents:compute-library(ref). It was pointed before thataclis quite a common acronym e.g. #5916, so I'm moving it to the official name.This PR just renames the mnemonic and adjust tests.
cc @u99127 @mbaret @comaniac