Move SimplifyConvPad to a new pass and don't enable it by default #7603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csullivan
approved these changes
Mar 5, 2021
Contributor
csullivan
left a comment
csullivan
left a comment
There was a problem hiding this comment.
Thanks for breaking this one out @mbrookhart
| return _ffi_api.SimplifyExpr() | ||
|
|
||
|
|
||
| def ImplicitPadding(): |
Contributor
There was a problem hiding this comment.
If we build up multiple patterns that can fuse implicit padding it may be useful to key on/off certain patterns based on operator type via a white or blacklist.
masahi
reviewed
Mar 5, 2021
masahi
reviewed
Mar 5, 2021
masahi
approved these changes
Mar 6, 2021
Member
|
Thanks @mbrookhart @csullivan |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ache#7603) * Move SimplifyConvPad to a new pass and don't enable it by default * rename pass * move files * fix lint * adjust test tolerance
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…ache#7603) * Move SimplifyConvPad to a new pass and don't enable it by default * rename pass * move files * fix lint * adjust test tolerance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7515 Caused a regression on the vulkan backend. This PR separates that optimization into a separate pass an disables it by default while we hunt for the issue in spirv.
cc @tmoreau89