Skip to content

Commit 83c7f4d

Browse files
authored
chore: add deprecations for PerformTouchAction and PerformMultiAction v2 (#553)
* chore: add deprecations for PerformTouchAction and PerformMultiAction in AppiumDriverCommand * chore: add deprecations for PerformMultiAction and PerformTouchAction in AppiumDriver * fix: Add missing [Obsolete] attribute
1 parent 46985b1 commit 83c7f4d

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/Appium.Net/Appium/AppiumDriver.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -377,23 +377,25 @@ public void DeactiveIMEEngine() =>
377377

378378
#endregion Input Method (IME)
379379

380-
#region Multi Actions
381-
380+
#region (Deprecated) Multi Actions
381+
// TODO: Remove this region once we deprecate the touch actions
382+
// Please use the W3C Actions instead.
383+
[Obsolete("Touch Actions are deprecated in W3C spec, please use W3C actions instead")]
382384
public void PerformMultiAction(IMultiAction multiAction)
383385
{
384386
if (multiAction == null) return;
385387
var parameters = multiAction.GetParameters();
386388
Execute(AppiumDriverCommand.PerformMultiAction, parameters);
387389
}
388-
390+
[Obsolete("Touch Actions are deprecated in W3C spec, please use W3C actions instead")]
389391
public void PerformTouchAction(ITouchAction touchAction)
390392
{
391393
if (touchAction == null) return;
392394
var parameters = AppiumCommandExecutionHelper.PrepareArgument("actions", touchAction.GetParameters());
393395
Execute(AppiumDriverCommand.PerformTouchAction, parameters);
394396
}
395397

396-
#endregion Multi Actions
398+
#endregion (Deprecated) Multi Actions
397399

398400
#region W3C Actions
399401

src/Appium.Net/Appium/AppiumDriverCommand.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,9 @@ public class AppiumDriverCommand
233233

234234
#endregion Appium Specific extensions to JSONWP Commands
235235

236-
#region TouchActions
236+
#region (Deprecated) TouchActions
237+
// TODO: Remove this region once we deprecate the touch actions
238+
// Please use the W3C Actions instead.
237239

238240
/// <summary>
239241
/// Perform touch action
@@ -245,7 +247,7 @@ public class AppiumDriverCommand
245247
/// </summary>
246248
public const string PerformMultiAction = "performMultiTouch";
247249

248-
#endregion MultiTouchActions
250+
#endregion (Deprecated) MultiTouchActions
249251

250252
#region W3C Actions
251253

0 commit comments

Comments
 (0)