Skip to content

Improve the performance of setting and parsing status code #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Improve the performance of setting and parsing status code #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43c78a4
Improve the performance of setting and parsing status code
guoye-zhang Nov 29, 2023
37e6cca
Fix format
guoye-zhang Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions Sources/HTTPTypes/HTTPResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,20 @@ public struct HTTPResponse: Sendable, Hashable {
}

var fieldValue: String {
String([
Character(Unicode.Scalar(UInt8(self.code / 100) + 48)),
Character(Unicode.Scalar(UInt8((self.code / 10) % 10) + 48)),
Character(Unicode.Scalar(UInt8(self.code % 10) + 48)),
])
if #available(macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0, *) {
return String(unsafeUninitializedCapacity: 3) { buffer in
buffer[0] = UInt8(self.code / 100) + 48
buffer[1] = UInt8((self.code / 10) % 10) + 48
buffer[2] = UInt8(self.code % 10) + 48
return 3
}
} else {
return String([
Character(Unicode.Scalar(UInt8(self.code / 100) + 48)),
Character(Unicode.Scalar(UInt8((self.code / 10) % 10) + 48)),
Character(Unicode.Scalar(UInt8(self.code % 10) + 48)),
])
}
}

static func isValidStatus(_ status: String) -> Bool {
Expand Down Expand Up @@ -149,7 +158,11 @@ public struct HTTPResponse: Sendable, Hashable {
/// phrase.
public var status: Status {
get {
Status(uncheckedCode: Int(self.pseudoHeaderFields.status.rawValue._storage)!, reasonPhrase: self.reasonPhrase)
var codeIterator = self.pseudoHeaderFields.status.rawValue._storage.utf8.makeIterator()
let code = Int(codeIterator.next()! - 48) * 100 +
Int(codeIterator.next()! - 48) * 10 +
Int(codeIterator.next()! - 48)
return Status(uncheckedCode: code, reasonPhrase: self.reasonPhrase)
}
set {
self.pseudoHeaderFields.status.rawValue = ISOLatin1String(unchecked: newValue.fieldValue)
Expand Down