Adopt NIOLock for more platform support #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Oct 23, 2024
| #endif | ||
| self.lock.deallocate() | ||
| } | ||
| let lock = LockStorage.create(value: ()) |
Member
There was a problem hiding this comment.
LockStorage is a class so it already gives us reference semantics. We should be able to drop the _Storage class here now and make it a struct. Then put that struct into the LockStorage that should save us an allocation.
Contributor
Author
There was a problem hiding this comment.
If we do that, both fields and index need to be a part of LockStorage. lock currently only protects index in the situation where there are multiple HTTPFields sharing the same storage. Can I add an unsafe accessor from LockStorage for fields access?
Member
There was a problem hiding this comment.
I see. I didn't know we just protected one. I think it's fine if we leave it as is in the PR. We can revisit later if we find that allocation problematic.
ekinnear
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is copied from with the addition of
os_unfair_lock: https://github.com/apple/swift-nio/blob/main/Sources/NIOConcurrencyHelpers/NIOLock.swift