Skip to content

Conversation

@JP-Ellis
Copy link

@JP-Ellis JP-Ellis commented Dec 4, 2014

Thanks to https://gist.github.com/czpython/7683425 for posting the fix.

This closes #136.

@codingjoe
Copy link
Collaborator

Hi @JP-Ellis,

feels weird to hardcode this option. At a first glance it seems to be an issue with the type casting. True might be render True not true.
https://github.com/applegrew/django-select2/blob/python3/django_select2/util.py#L127-L151

Could you check this?

Cheers,
joe

@JP-Ellis
Copy link
Author

I'm sorry, but I don't quite understand where you're coming from. How are those lines you highlighted relevant?

I'm not longer using this Django app as I have found another one to fit my needs better. I have left this pull request open in case it was of interest to anyone. If you wish, I can give you write access to my fork so you can do whatever changes you want and then pull it.

@codingjoe
Copy link
Collaborator

Haha, I'm coming from Berlin, and thanks, I don't need access to your remote repo. But thanks.

I don't feel comfortable merging the PR, it isn't solving the error cause rather patching one symptom. Therefore I will close the PR but the bug report is much appreciated and noted in #146

@codingjoe codingjoe closed this Feb 24, 2015
@codingjoe codingjoe mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants