[skip-changelog] Fix integration test runner (#2986)

cmaglie · web-flow · commit 869fced25452 · 2025-08-27T15:44:43.000+02:00
diff --git a/internal/integrationtest/arduino-cli.go b/internal/integrationtest/arduino-cli.go
@@ -410,16 +410,16 @@ func (cli *ArduinoCLI) run(ctx context.Context, stdoutBuff, stderrBuff io.Writer
 		}
 	}()
 	if stdinBuff != nil {
+		wg.Add(1)
 		go func() {
+			defer wg.Done()
 			if _, err := io.Copy(stdin, stdinBuff); err != nil {
 				fmt.Fprintln(terminalErr, color.HiBlackString("<<< stdin copy error:"), err)
 			}
 		}()
 	}
-	cliErr := cliProc.WaitWithinContext(ctx)
 	wg.Wait()
-
-	return cliErr
+	return cliProc.WaitWithinContext(ctx)
 }
 
 // StartDaemon starts the Arduino CLI daemon. It returns the address of the daemon.

Original file line number	Diff line number	Diff line change
`@@ -410,16 +410,16 @@ func (cli *ArduinoCLI) run(ctx context.Context, stdoutBuff, stderrBuff io.Writer`
`410`	`410`	`}`
`411`	`411`	`}()`
`412`	`412`	`if stdinBuff != nil {`
	`413`	`+ wg.Add(1)`
`413`	`414`	`go func() {`
	`415`	`+ defer wg.Done()`
`414`	`416`	`if _, err := io.Copy(stdin, stdinBuff); err != nil {`
`415`	`417`	`fmt.Fprintln(terminalErr, color.HiBlackString("<<< stdin copy error:"), err)`
`416`	`418`	`}`
`417`	`419`	`}()`
`418`	`420`	`}`
`419`		`- cliErr := cliProc.WaitWithinContext(ctx)`
`420`	`421`	`wg.Wait()`
`421`		`-`
`422`		`- return cliErr`
	`422`	`+ return cliProc.WaitWithinContext(ctx)`
`423`	`423`	`}`
`424`	`424`
`425`	`425`	`// StartDaemon starts the Arduino CLI daemon. It returns the address of the daemon.`