fix: incorrect certificate flashing command string

Use a `string` array of command flags instead of the concatenated final
`string` command.

Ref: #2067

Closes #2179

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/contributions/upload-certificate.ts

@@ -19,6 +19,12 @@ import {
 import { ArduinoFirmwareUploader } from '../../common/protocol/arduino-firmware-uploader';
 import { nls } from '@theia/core/lib/common';
 
+interface UploadCertificateParams {
+  readonly fqbn: string;
+  readonly address: string;
+  readonly urls: readonly string[];
+}
+
 @injectable()
 export class UploadCertificate extends Contribution {
   @inject(UploadCertificateDialog)
@@ -74,12 +80,17 @@ export class UploadCertificate extends Contribution {
     });
 
     registry.registerCommand(UploadCertificate.Commands.UPLOAD_CERT, {
-      execute: async ({ fqbn, address, urls }) => {
-        return this.arduinoFirmwareUploader.uploadCertificates(
-          `-b ${fqbn} -a ${address} ${urls
-            .map((url: string) => `-u ${url}`)
-            .join(' ')}`
-        );
+      execute: async (params: UploadCertificateParams) => {
+        const { fqbn, address, urls } = params;
+        return this.arduinoFirmwareUploader.uploadCertificates({
+          flags: [
+            '-b',
+            fqbn,
+            '-a',
+            address,
+            ...urls.flatMap((url) => ['-u', url]),
+          ],
+        });
       },
     });
 

arduino-ide-extension/src/common/protocol/arduino-firmware-uploader.ts

@@ -1,4 +1,4 @@
-import { Port } from "./boards-service";
+import type { Port } from './boards-service';
 
 export const ArduinoFirmwareUploaderPath =
   '/services/arduino-firmware-uploader';
@@ -13,7 +13,7 @@ export type FirmwareInfo = {
 export interface ArduinoFirmwareUploader {
   list(fqbn?: string): Promise<FirmwareInfo[]>;
   flash(firmware: FirmwareInfo, port: Port): Promise<string>;
-  uploadCertificates(command: string): Promise<any>;
+  uploadCertificates(params: { flags: string[] }): Promise<any>;
   updatableBoards(): Promise<string[]>;
   availableFirmwares(fqbn: string): Promise<FirmwareInfo[]>;
 }

arduino-ide-extension/src/node/arduino-firmware-uploader-impl.ts

@@ -17,8 +17,8 @@ export class ArduinoFirmwareUploaderImpl implements ArduinoFirmwareUploader {
   @inject(MonitorManager)
   private readonly monitorManager: MonitorManager;
 
-  async uploadCertificates(command: string): Promise<string> {
-    return await this.runCommand(['certificates', 'flash', command]);
+  async uploadCertificates(params: { flags: string[] }): Promise<string> {
+    return await this.runCommand(['certificates', 'flash', ...params.flags]);
   }
 
   async list(fqbn?: string): Promise<FirmwareInfo[]> {