Merge pull request #394 from atom/show-prompt-always

Show fast mode prompt on any project size

Author: rafeca

lib/experiment-prompt.js

@@ -2,11 +2,6 @@ const etch = require('etch')
 const $ = etch.dom
 const SCORING_SYSTEMS = require('./scoring-systems')
 
-/**
- * Minimum number of files in the project needed to show the fast mode prompt.
- */
-const ThresholdForShowingPrompt = 10000
-
 /**
  * For how long to show the "NEW" badge in the prompt since the first time
  * it was seen (24h).
@@ -20,7 +15,7 @@ function shouldShowPrompt (numItems) {
     return false
   }
 
-  return isFastModeEnabled() || numItems > ThresholdForShowingPrompt
+  return true
 }
 
 function shouldShowBadge () {

spec/buffer-view-spec.js

@@ -5,7 +5,7 @@ const BufferView = require('../lib/buffer-view')
 
 describe('BufferView', () => {
   it('shows the avatar for editors that are remote', async () => {
-    const bufferView = new BufferView()
+    const bufferView = new BufferView({incrementCounter: () => {}})
 
     const localEditor1 = await atom.workspace.open(path.join(temp.path(), 'a'))
     const localEditor2 = await atom.workspace.open(path.join(temp.path(), 'b'))

spec/fuzzy-finder-spec.js

@@ -30,10 +30,17 @@ function getOrScheduleUpdatePromise () {
 }
 
 describe('FuzzyFinder', () => {
+  let disposable, reporterStub
   let rootDir1, rootDir2
   let fuzzyFinder, projectView, bufferView, gitStatusView, workspaceElement, fixturesPath
 
   beforeEach(async () => {
+    reporterStub = {
+      addTiming: sinon.spy(),
+      incrementCounter: () => {}
+    }
+    disposable = fuzzyFinderPackage.consumeMetricsReporter(reporterStub)
+
     const ancestorDir = fs.realpathSync(temp.mkdirSync())
     rootDir1 = path.join(ancestorDir, 'root-dir1')
     rootDir2 = path.join(ancestorDir, 'root-dir2')
@@ -66,6 +73,12 @@ describe('FuzzyFinder', () => {
     jasmine.useRealClock()
   })
 
+  afterEach(() => {
+    if (disposable) {
+      disposable.dispose()
+    }
+  })
+
   async function waitForPathsToDisplay (fuzzyFinderView) {
     return conditionPromise(() => fuzzyFinderView.element.querySelectorAll('li').length > 0)
   }
@@ -1658,21 +1671,7 @@ describe('FuzzyFinder', () => {
         })
 
         describe('logging of metrics events', () => {
-          let disposable
-
-          afterEach(() => {
-            if (disposable) {
-              disposable.dispose()
-            }
-          })
-
           it('logs the crawling time', async () => {
-            const reporterStub = {
-              addTiming: sinon.spy()
-            }
-
-            disposable = fuzzyFinderPackage.consumeMetricsReporter(reporterStub)
-
             // After setting the reporter it may receive some old events from previous tests
             // that we want to discard.
             reporterStub.addTiming.reset()
@@ -1688,10 +1687,6 @@ describe('FuzzyFinder', () => {
           })
 
           it('queues the events until a reporter is set', async () => {
-            const reporterStub = {
-              addTiming: sinon.spy()
-            }
-
             // After setting the reporter it may receive some old events from previous tests
             // that we want to discard.
             reporterStub.addTiming.reset()