e2e: Ensure e2e.test is built with portable BLST #1734
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
approved these changes
Jul 19, 2023
Contributor
|
What about #1714 (comment) ? |
darioush
approved these changes
Jul 19, 2023
PR #1714 factored ANR installation into a common script, but in the process removed the CGO configuration for BLST from tests.e2e.sh. The result was sporadic e2e job failure whenever the github worker vm was missing the instructions non-portable BLST required. Ensuring CGO is explicitly configured for portable BLST in tests.e2e.sh should ensure the e2e test binary can once again be built reliably.
marun
force-pushed
the
e2e-fix-cgo-config
branch
from
3cff14e to
d61023e
Compare
Contributor
Author
As per slack convo, running a script doesn't modify the executing shell. It's necessary to source constants in the test scripts to ensure the env vars are available to test compilation. |
Contributor
Author
|
Updated to fix the upgrade script and remove the superfluous sourcing of constants.sh from the anr installation script. |
abi87
approved these changes
Jul 19, 2023
StephenButtolph
approved these changes
Jul 19, 2023
StephenButtolph
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
PR #1714 factored ANR installation into a common script, but in the process removed the CGO configuration for BLST from tests.e2e.sh. The result was sporadic e2e job failure whenever the github worker vm was missing the instructions non-portable BLST required. Ensuring CGO is explicitly configured for portable BLST in tests.e2e.sh should ensure the e2e test binary can once again be built reliably.
How this works
How this was tested