Skip to content

upgrade: Increase all ANR timeouts to 2m to ensure CI reliability #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

upgrade: Increase all ANR timeouts to 2m to ensure CI reliability #1737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions tests/upgrade/upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import (
"github.com/ava-labs/avalanchego/tests"
)

const DefaultTimeout = 2 * time.Minute

func TestUpgrade(t *testing.T) {
gomega.RegisterFailHandler(ginkgo.Fail)
ginkgo.RunSpecs(t, "upgrade test suites")
Expand Down Expand Up @@ -82,14 +84,14 @@ var _ = ginkgo.BeforeSuite(func() {
})
gomega.Expect(err).Should(gomega.BeNil())

ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
ctx, cancel := context.WithTimeout(context.Background(), DefaultTimeout)
presp, err := runnerCli.Ping(ctx)
cancel()
gomega.Expect(err).Should(gomega.BeNil())
tests.Outf("{{green}}network-runner running in PID %d{{/}}\n", presp.Pid)

tests.Outf("{{magenta}}starting network-runner with %q{{/}}\n", networkRunnerAvalancheGoExecPath)
ctx, cancel = context.WithTimeout(context.Background(), 15*time.Second)
ctx, cancel = context.WithTimeout(context.Background(), DefaultTimeout)
resp, err := runnerCli.Start(ctx, networkRunnerAvalancheGoExecPath,
runner_sdk.WithNumNodes(5),
runner_sdk.WithGlobalNodeConfig(fmt.Sprintf(`{"log-level":"%s"}`, networkRunnerAvalancheGoLogLevel)),
Expand All @@ -98,18 +100,15 @@ var _ = ginkgo.BeforeSuite(func() {
gomega.Expect(err).Should(gomega.BeNil())
tests.Outf("{{green}}successfully started network-runner: {{/}} %+v\n", resp.ClusterInfo.NodeNames)

// start is async, so wait some time for cluster health
time.Sleep(time.Minute)

ctx, cancel = context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel = context.WithTimeout(context.Background(), DefaultTimeout)
_, err = runnerCli.Health(ctx)
cancel()
gomega.Expect(err).Should(gomega.BeNil())
})

var _ = ginkgo.AfterSuite(func() {
tests.Outf("{{red}}shutting down network-runner cluster{{/}}\n")
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), DefaultTimeout)
_, err := runnerCli.Stop(ctx)
cancel()
gomega.Expect(err).Should(gomega.BeNil())
Expand All @@ -122,21 +121,19 @@ var _ = ginkgo.AfterSuite(func() {
var _ = ginkgo.Describe("[Upgrade]", func() {
ginkgo.It("can upgrade versions", func() {
tests.Outf("{{magenta}}starting upgrade tests %q{{/}}\n", networkRunnerAvalancheGoExecPathToUpgrade)
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
ctx, cancel := context.WithTimeout(context.Background(), DefaultTimeout)
sresp, err := runnerCli.Status(ctx)
cancel()
gomega.Expect(err).Should(gomega.BeNil())

for _, name := range sresp.ClusterInfo.NodeNames {
tests.Outf("{{magenta}}restarting the node %q{{/}} with %q\n", name, networkRunnerAvalancheGoExecPathToUpgrade)
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), DefaultTimeout)
resp, err := runnerCli.RestartNode(ctx, name, runner_sdk.WithExecPath(networkRunnerAvalancheGoExecPathToUpgrade))
cancel()
gomega.Expect(err).Should(gomega.BeNil())

time.Sleep(20 * time.Second)

ctx, cancel = context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel = context.WithTimeout(context.Background(), DefaultTimeout)
_, err = runnerCli.Health(ctx)
cancel()
gomega.Expect(err).Should(gomega.BeNil())
Expand Down