added challenge question for user to retrieve the elb URL #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalbhanj
suggested changes
Nov 21, 2018
* Batch Processing Workshop (all except advanced example) * Add advanced batch example * Updates based on feedback on PR-133 * Change S3 bucket creation to use AWSCLI * Add IAM policy for artifact S3 access * Add removal instructions for S3 IAM policy * Duplicate ACCOUNT_ID creation per code block where it's used * Clean S3 IAM policy steps * Fix error in ConfigMap for artifact repository (manual substitution) * Delete non-empty bucket
* updating to support cloud9 dev environment * updating repo urls for consistency * commit the link fixes
* Tracing with X-Ray module * Change urls to deployed version
aws-samples#131) * added documentation and examples to demo readiness and liveness probes * simplified text boxes for commands, added additional explanation about how probes work and tweaked readiness probe * added step to make readiness probe pass after failure * updated the folder structure to reflect http paths and guidelines * updated the pages to show and explain the yaml files instead of simply downloading the same * minor edits to add clarity
* updating to support cloud9 dev environment * updating repo urls for consistency * remove duplicate instructions page?
* adding calico chapter * deleting calico in cleanup step * changing notice from note(blue) to tip(green) * changing chapter weight to fit between example microservices and helm * adding uninstall calico text * separated command from the output * reverting changes to package-lock.json * adding all changes except yaml creation * changing calico resources from links to local files * moved cloning the repo from prereqs to calico chapter * changed dynamic volue hyperlink to k8s doc
minor grammar changes
* adding monitoring using prometheus & grafana chapter * changing draft: false * minor change to grafana dashboards * adding challenge question & offering solution * formatting changes - removed for re-emphasizing * minor change with relative links
* Remove region * fixing backticks
* Added challenge question to installnginx.md Challenge question provides clues for the correct helm install syntax. Workshop participant can either figure out the syntax themselves or expand the hidden text for the correct command. * Updated Challenge Formatting and Module Wording Changed the formatting of the challenge to match the requested styling. Made the warning about the ELB creation time more obvious. Miscellaneous wording corrections.
* Update _index.md Fixing some grammar and typos. * Update introduction.md Fixed some formatting and grammar. * Update install.md Cleaning up formatting and grammar. * Update deploy.md Fixed grammar and formatting. * Update routing.md Grammar and typo fixes. * Update visualize.md fixed some grammar and typos * Update cleanup.md Cleaning up grammar and typos * Update routing.md Fixed error language message to better illustrate what to expect. * Update _index.md Removing callout
* adding monitoring using prometheus & grafana chapter * changing draft: false * minor change to grafana dashboards * adding challenge question & offering solution * formatting changes - removed for re-emphasizing * minor change with relative links * fixing typo in health checks chapter * minor improvements in health check chapter
Added command to map $ROLE_NAME in case this was lost
… workflow (aws-samples#143) * adding calico chapter * deleting calico in cleanup step * changing notice from note(blue) to tip(green) * changing chapter weight to fit between example microservices and helm * adding uninstall calico text * separated command from the output * reverting changes to package-lock.json * adding all changes except yaml creation * changing calico resources from links to local files * moved cloning the repo from prereqs to calico chapter * changed dynamic volue hyperlink to k8s doc * changed calico chapter index image to official project calico logo * added a note for pods scaling duration * replaced workflow name from command with placeholder * improved changes introduced in commit 5f627f6
Contributor
|
@vjsikha still has commits to cicd chapter. Please remove these changes and send commits to health checks chapter only /content/codepipeline/codepipeline.md |
Contributor
|
@vjsikha How do you feel about moving that challenge to the page before? We do the same step to get the ELB so it feels more natural to put it there. |
brentley
suggested changes
Nov 21, 2018
| @@ -1,5 +1,5 @@ | |||
| <a | |||
| href="https://console.aws.amazon.com/cloudformation/home?#/stacks/quickcreate?stackName={{ .Get 1 }}&templateURL=https://s3.amazonaws.com/{{ $.Site.Params.template_bucket }}/templates/{{ $.Site.Params.branch }}/{{ .Get 0 }}" | |||
| href="https://console.aws.amazon.com/cloudformation/home?#/stacks/create/review?stackName={{ .Get 0 }}&templateURL=https://s3.amazonaws.com/{{ $.Site.Params.template_bucket }}/templates/{{ $.Site.Params.branch }}/{{ .Get 1 }}" | |||
Contributor
There was a problem hiding this comment.
I believe this file is part of an earlier version of the codebase, and this diff is reverting back to the older version. Please remove it from this PR.
Contributor
Author
There was a problem hiding this comment.
agreed. confirmed that it's an issue when user is on old version of Cloud Formation console. We will convey that all users must be on the newer version. reverting these changes
Contributor
|
should we close this PR in favor of #172 |
brentley
reviewed
Nov 21, 2018
| | Launch template | | | | ||
| | ------ |:------:|:--------:| | ||
| | CodePipeline & EKS | {{% cf-launch "ci-cd-codepipeline.cfn.yml" "eksws-codepipeline" %}} | {{% cf-download "ci-cd-codepipeline.cfn.yml" %}} | | ||
| | CodePipeline & EKS | {{% cf-launch "eksws-codepipeline" "ci-cd-codepipeline.cfn.yml" %}} | {{% cf-download "ci-cd-codepipeline.cfn.yml" %}} | |
Contributor
There was a problem hiding this comment.
not sure if this also needs to be reverted since reverting the commit in cf-launch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#157
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.