Commit 32b6b4d
authored
fix(custom-resources):
### Issue # (if applicable)
Closes #23260
Also #34011
### Reason for this change
According [to the documentation](https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html), the `RoleSessionName` property for an `AssumeRole` operation may only contain upper- and lower-case alphanumeric characters with no spaces, underscores or any of the following characters: =,.@-
### Description of changes
Sanitize the role session name by removing all non-allowed symbols
### Describe any new or updated permissions being added
N/A
### Description of how you validated changes
- [x] Unit Test
- [x] Integration Test
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*AwsCustomResource assumed role session name may contain invalid characters (#34016)1 parent 2e95252 commit 32b6b4d
File tree
196 files changed
+99867
-107538
lines changed- packages
- @aws-cdk-testing/framework-integ/test
- aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- aws-elasticloadbalancingv2/test/integ.alb.oidc.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- aws-elasticsearch/test
- integ.elasticsearch.custom-kms-key.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- integ.elasticsearch.unsignedbasicauth.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- aws-events-targets/test/logs
- integ.log-group-from-object-v2.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- integ.log-group.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- asset.9e8936ba1db43e0919ba2fc8265d50686eeaca82830c471ff8b7b0672c5970ec
- aws-globalaccelerator-endpoints/test/integ.globalaccelerator.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- aws-logs-destinations/test/integ.lambda.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- aws-opensearchservice/test
- integ.opensearch.custom-kms-key.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- integ.opensearch.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- integ.opensearch.unsignedbasicauth.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- aws-route53/test/integ.vpc-endpoint-service-domain-name.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- asset.f692c9f68e4daba2abc99103efd3518bced1e9d7a2a89847b9b5d5473c64f1bd.bundle
- aws-s3/test/integ.bucket-auto-delete-objects.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- aws-synthetics/test/integ.canary-auto-delete-lambda.js.snapshot
- custom-resources/test/aws-custom-resource
- integ.aws-custom-resource-assumeRole.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- integ.aws-custom-resource-athena.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- asset.f692c9f68e4daba2abc99103efd3518bced1e9d7a2a89847b9b5d5473c64f1bd.bundle
- integ.aws-custom-resource-dynamodb.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- integ.aws-custom-resource-service-timeout.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- integ.aws-custom-resource-vpc.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- integ.aws-custom-resource.js.snapshot
- asset.695130a6c8132c255e833e84e8482a4a144a4a1261c979bd7e3cb7b8258e8876
- asset.97484721f29e34bf38d7a459804dd2d2a8dea6f8c27d7531e215bf4274fbc895.bundle
- asset.cde607091ceabfbfb56e643cd4a5647680cfaf19c63f4d59b3f4880df4a71c8d
- asset.f692c9f68e4daba2abc99103efd3518bced1e9d7a2a89847b9b5d5473c64f1bd.bundle
- @aws-cdk/custom-resource-handlers
- lib/custom-resources/aws-custom-resource-handler
- test/custom-resources/aws-custom-resource
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
196 files changed
+99867
-107538
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 9 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
827 | 827 | | |
828 | 828 | | |
829 | 829 | | |
830 | | - | |
| 830 | + | |
831 | 831 | | |
832 | 832 | | |
833 | 833 | | |
| |||
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments