Commit 9d79c51
authored
fix(appconfig): sourcedConfiguration doesn't use retrievalRole (#30733)
### Issue # (if applicable)
Closes #30609
### Reason for this change
To refactor the retrievalRole creation logic.
### Description of changes
### Description of how you validated changes
Unit tests:
1. configuration with retrievalRole undefined from bucket source should create a new role
2. configuration with retrievalRole defined should NOT create a new role and should use the passed role for the retrievalRoleArn
3. configuration with retrievalRole undefined from CodePipeline source should NOT create a new role
Integ test:
1. update the existing integ test to assert a use case where the retrievalRole is provided.
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 742c52e commit 9d79c51
File tree
9 files changed
+1393
-340
lines changed- packages
- @aws-cdk-testing/framework-integ/test/aws-appconfig/test
- integ.configuration.js.snapshot
- asset.0158f40002a8c211635388a87874fd4dcc3d68f525fe08a0fe0f014069ae539c
- asset.44e9c4d7a5d3fd2d677e1a7e416b2b56f6b0104bd5eff9cac5557b4c65a9dc61
- aws-cdk-lib/aws-appconfig
- lib
- test
9 files changed
+1393
-340
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 18 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments