Skip to content

Conversation

@justsmth
Copy link
Contributor

Issues:

N/A

Description of changes:

Update to latest version of AWS-LC.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner August 21, 2023 18:44
skmcgrail
skmcgrail previously approved these changes Aug 21, 2023
@dkostic dkostic self-requested a review August 22, 2023 17:15
dkostic
dkostic previously approved these changes Aug 22, 2023
@justsmth
Copy link
Contributor Author

The ppc64le cross-compilation test failed: https://github.com/aws/aws-lc-rs/actions/runs/5930239156/job/16079549335?pr=222

  Copying platform assembly files from /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/aws-lc/generated-src/linux-ppc64le/crypto/ to /target/powerpc64le-unknown-linux-gnu/release/build/aws-lc-sys-461259088f0babac/out/build/aws-lc/crypto
  In file included from /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/aws-lc/crypto/fipsmodule/bcm.c:121:
  /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/aws-lc/crypto/fipsmodule/modes/gcm.c: In function 'aws_lc_0_10_0_CRYPTO_ghash_init':
  /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/aws-lc/crypto/fipsmodule/modes/gcm.c:293:15: error: assignment to 'gmult_func' {aka 'void (*)(unsigned char *, const struct <anonymous> *)'} from incompatible pointer type 'void (*)(uint64_t *, const u128 *)' {aka 'void (*)(long unsigned int *, const struct <anonymous> *)'} [-Werror=incompatible-pointer-types]
    293 |     *out_mult = gcm_gmult_p8;
        |               ^
  /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/aws-lc/crypto/fipsmodule/modes/gcm.c:294:15: error: assignment to 'ghash_func' {aka 'void (*)(unsigned char *, const struct <anonymous> *, const unsigned char *, long unsigned int)'} from incompatible pointer type 'void (*)(uint64_t *, const u128 *, const uint8_t *, size_t)' {aka 'void (*)(long unsigned int *, const struct <anonymous> *, const unsigned char *, long unsigned int)'} [-Werror=incompatible-pointer-types]
    294 |     *out_hash = gcm_ghash_p8;
        |               ^
  cc1: all warnings being treated as errors
  make[2]: *** [aws-lc/crypto/fipsmodule/CMakeFiles/fipsmodule.dir/build.make:76: aws-lc/crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o] Error 1
  make[1]: *** [CMakeFiles/Makefile2:257: aws-lc/crypto/fipsmodule/CMakeFiles/fipsmodule.dir/all] Error 2

@justsmth justsmth marked this pull request as draft August 23, 2023 16:15
@justsmth justsmth dismissed stale reviews from dkostic and skmcgrail via a4f5e76 August 29, 2023 20:21
@justsmth justsmth marked this pull request as ready for review August 29, 2023 21:25
@justsmth justsmth requested review from dkostic and skmcgrail August 30, 2023 13:49
@justsmth justsmth merged commit 5b529cb into aws:main Aug 31, 2023
@justsmth justsmth deleted the aws-lc-sys-0.10.0 branch January 23, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants