Conditionally enable Neon version of s2n-bignum implementations for montgomery multiplications #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebeid
reviewed
Aug 18, 2023
nebeid
approved these changes
Aug 21, 2023
dkostic
approved these changes
Aug 22, 2023
Contributor
Author
|
Thank you for reviews! It seems I don't have a permission to merge this pull request. Could anyone merge this for me please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This patch is the last patch splitted from #1108 for improving RSA signature speed for Graviton 2.
This conditionally enables the the Neon versions of verified primitives of s2n-bignum when
CRYPTO_is_NEON_capable()is true.The scalar versions of s2n-bignum primitives are already merged in b706d7e.
The performance improvements of RSA signatures on Graviton 2 are as follows (Unit: ops/sec).
Testing:
Tested via
bssl speed -filter RSABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.