Skip to content

Commit f5876e0

Browse files
committed
Move CrtRequestBodyAdapter to crt-core
1 parent cd72dbf commit f5876e0

File tree

5 files changed

+20
-55
lines changed

5 files changed

+20
-55
lines changed
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* permissions and limitations under the License.
1414
*/
1515

16-
package software.amazon.awssdk.http.auth.aws.crt.internal.signer;
16+
package software.amazon.awssdk.crtcore;
1717

1818
import java.nio.ByteBuffer;
1919
import org.reactivestreams.Publisher;
@@ -29,10 +29,14 @@ public final class CrtRequestBodyAdapter implements HttpRequestBodyStream {
2929
private final long contentLength;
3030
private ByteBufferStoringSubscriber requestBodySubscriber;
3131

32-
public CrtRequestBodyAdapter(Publisher<ByteBuffer> requestPublisher, long contentLength) {
32+
public CrtRequestBodyAdapter(Publisher<ByteBuffer> requestPublisher, long contentLength, long readLimit) {
3333
this.requestPublisher = requestPublisher;
3434
this.contentLength = contentLength;
35-
this.requestBodySubscriber = new ByteBufferStoringSubscriber(BUFFER_SIZE);
35+
this.requestBodySubscriber = new ByteBufferStoringSubscriber(readLimit);
36+
}
37+
38+
public CrtRequestBodyAdapter(Publisher<ByteBuffer> requestPublisher, long contentLength) {
39+
this(requestPublisher, contentLength, BUFFER_SIZE);
3640
}
3741

3842
@Override

core/http-auth-aws/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,12 @@
6969
<artifactId>checksums</artifactId>
7070
<version>${awsjavasdk.version}</version>
7171
</dependency>
72+
<dependency>
73+
<groupId>software.amazon.awssdk</groupId>
74+
<artifactId>crt-core</artifactId>
75+
<version>${awsjavasdk.version}</version>
76+
<optional>true</optional>
77+
</dependency>
7278
<dependency>
7379
<groupId>software.amazon.awssdk</groupId>
7480
<artifactId>http-auth-aws-crt</artifactId>

core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/crt/internal/util/CrtHttpRequestConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
import software.amazon.awssdk.crt.http.HttpHeader;
2929
import software.amazon.awssdk.crt.http.HttpRequest;
3030
import software.amazon.awssdk.crt.http.HttpRequestBodyStream;
31+
import software.amazon.awssdk.crtcore.CrtRequestBodyAdapter;
3132
import software.amazon.awssdk.http.ContentStreamProvider;
3233
import software.amazon.awssdk.http.SdkHttpRequest;
3334
import software.amazon.awssdk.http.auth.aws.crt.internal.io.CrtInputStream;
34-
import software.amazon.awssdk.http.auth.aws.crt.internal.signer.CrtRequestBodyAdapter;
3535
import software.amazon.awssdk.utils.StringUtils;
3636
import software.amazon.awssdk.utils.http.SdkHttpUtils;
3737
import software.amazon.awssdk.utils.uri.SdkUri;

http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/request/CrtRequestAdapter.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,12 @@
2222
import software.amazon.awssdk.annotations.SdkInternalApi;
2323
import software.amazon.awssdk.crt.http.HttpHeader;
2424
import software.amazon.awssdk.crt.http.HttpRequest;
25+
import software.amazon.awssdk.crtcore.CrtRequestBodyAdapter;
2526
import software.amazon.awssdk.http.Header;
2627
import software.amazon.awssdk.http.HttpExecuteRequest;
2728
import software.amazon.awssdk.http.SdkHttpRequest;
2829
import software.amazon.awssdk.http.async.AsyncExecuteRequest;
30+
import software.amazon.awssdk.http.async.SdkHttpContentPublisher;
2931
import software.amazon.awssdk.http.crt.internal.CrtAsyncRequestContext;
3032
import software.amazon.awssdk.http.crt.internal.CrtRequestContext;
3133

@@ -50,10 +52,13 @@ public static HttpRequest toAsyncCrtRequest(CrtAsyncRequestContext request) {
5052

5153
HttpHeader[] crtHeaderArray = asArray(createAsyncHttpHeaderList(sdkRequest.getUri(), sdkExecuteRequest));
5254

55+
SdkHttpContentPublisher contentPublisher = sdkExecuteRequest.requestContentPublisher();
56+
5357
return new HttpRequest(method,
5458
encodedPath + encodedQueryString,
5559
crtHeaderArray,
56-
new CrtRequestBodyAdapter(sdkExecuteRequest.requestContentPublisher(),
60+
new CrtRequestBodyAdapter(contentPublisher,
61+
contentPublisher.contentLength().orElse(0L),
5762
request.readBufferSize()));
5863
}
5964

http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/request/CrtRequestBodyAdapter.java

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)