feat(smithy-client): implement SdkException class #3261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2022
Contributor
Author
|
After discussing offline, we are going to rename the base class name from |
AllanZhengYP
force-pushed
the
design-exception
branch
from
c27d8be to
cdfc9d8
Compare
AllanZhengYP
force-pushed
the
design-exception
branch
from
17a60b2 to
1def8ba
Compare
trivikr
approved these changes
Jan 29, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1506
#2007
Description
ServiceExceptionclass as a base class for all the server-side exception classes. The refactor to the deserializer will come next. It implements the mostly the same interface asSdkError.SdkErrorinterface is deprecated because it is not used/enforced in actual exceptions thrown from the deserializer. It cannot be changed toServiceExceptionclass because it declares every member as optional. However, theSdkExceptioncontains required members(message,name), simply keeping the name will cause breaking change to anyone consuming theSdkErrorinterface.SmithyExceptoininterface is deprecated for the same reason.Testing
TBD
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.