Skip to content

Commit 95731a6

Browse files
authored
Remove support for Node 10.x (#512)
1 parent 16cf302 commit 95731a6

File tree

15 files changed

+12
-25
lines changed

15 files changed

+12
-25
lines changed

.github/workflows/pr-build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ jobs:
1717
- ubuntu-latest
1818
- windows-latest
1919
node-version:
20-
- 10.x
2120
- 12.x
2221
- 14.x
2322
- 15.x

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
## Installing
88

9-
The AWS X-Ray SDK for Node.js is compatible with Node.js version 10.x and later.
9+
The AWS X-Ray SDK for Node.js is compatible with Node.js version 12.x and later.
1010
There may be issues when running on the latest odd-numbered release of Node.js.
1111

1212
The latest stable version of the SDK is available from NPM. For local development, install the SDK in your project directory with npm.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"upath": "^1.2.0"
5252
},
5353
"engines": {
54-
"node": ">= 10.x",
54+
"node": ">= 12.x",
5555
"npm": ">= 2.x"
5656
},
5757
"dependencies": {

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"main": "dist/lib/index.js",
1717
"types": "dist/lib/index.d.ts",
1818
"engines": {
19-
"node": ">= 10.x"
19+
"node": ">= 12.x"
2020
},
2121
"directories": {
2222
"test": "test"

packages/express/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"main": "lib/index.js",
1010
"types": "lib/index.d.ts",
1111
"engines": {
12-
"node": ">= 10.x"
12+
"node": ">= 12.x"
1313
},
1414
"directories": {
1515
"test": "test"

packages/full_sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"main": "lib/index.js",
1111
"types": "lib/index.d.ts",
1212
"engines": {
13-
"node": ">= 10.x"
13+
"node": ">= 12.x"
1414
},
1515
"dependencies": {
1616
"aws-xray-sdk-core": "file:../core",

packages/mysql/lib/mysql_p.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,6 @@ function captureOperation(name) {
237237
if (!args.callback) {
238238
var errorCapturer = function (err) {
239239
subsegment.close(err);
240-
241-
// TODO: Remove this logic once Node 10 is deprecated
242-
if (!events.errorMonitor && this.listenerCount('error') <= 1) {
243-
this.removeListener('error', errorCapturer);
244-
this.emit('error', err);
245-
}
246240
};
247241

248242
if (isPromise(command)) {

packages/mysql/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"main": "lib/index.js",
1010
"types": "lib/index.d.ts",
1111
"engines": {
12-
"node": ">= 10.x"
12+
"node": ">= 12.x"
1313
},
1414
"directories": {
1515
"test": "test"

packages/postgres/lib/postgres_p.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,6 @@ function captureQuery() {
111111

112112
var errorCapturer = function (err) {
113113
subsegment.close(err);
114-
115-
// TODO: Remove this logic once Node 10 is deprecated
116-
if (!events.errorMonitor && this.listenerCount('error') <= 1) {
117-
this.removeListener('error', errorCapturer);
118-
this.emit('error', err);
119-
}
120114
};
121115

122116
query.on(events.errorMonitor || 'error', errorCapturer);

packages/postgres/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"main": "lib/index.js",
1010
"types": "lib/index.d.ts",
1111
"engines": {
12-
"node": ">= 10.x"
12+
"node": ">= 12.x"
1313
},
1414
"directories": {
1515
"test": "test"

0 commit comments

Comments
 (0)