Skip to content

Commit c12135c

Browse files
author
Satish Pasumarthi
committed
fix: CI changes
1 parent 88ca48a commit c12135c

File tree

10 files changed

+52
-13
lines changed

10 files changed

+52
-13
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ information to effectively respond to your bug report or contribution.
1111

1212
We welcome you to use the GitHub issue tracker to report bugs or suggest features.
1313

14-
When filing an issue, please check [existing open](https://github.com/aws-samples/sagemaker-pytorch-containers/issues), or [recently closed](https://github.com/aws-samples/sagemaker-pytorch-containers/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), issues to make sure somebody else hasn't already
14+
When filing an issue, please check [existing open](https://github.com/aws/sagemaker-pytorch-training-toolkit/issues), or [recently closed](https://github.com/aws/sagemaker-pytorch-training-toolkit/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), issues to make sure somebody else hasn't already
1515
reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:
1616

1717
* A reproducible test case or series of steps
@@ -41,7 +41,7 @@ GitHub provides additional document on [forking a repository](https://help.githu
4141

4242

4343
## Finding contributions to work on
44-
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels ((enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any ['help wanted'](https://github.com/aws-samples/sagemaker-pytorch-containers/labels/help%20wanted) issues is a great place to start.
44+
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels ((enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any ['help wanted'](https://github.com/aws/sagemaker-pytorch-training-toolkit/labels/help%20wanted) issues is a great place to start.
4545

4646

4747
## Code of Conduct
@@ -56,6 +56,6 @@ If you discover a potential security issue in this project we ask that you notif
5656

5757
## Licensing
5858

59-
See the [LICENSE](https://github.com/aws-samples/sagemaker-pytorch-containers/blob/master/LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
59+
See the [LICENSE](https://github.com/aws/sagemaker-pytorch-training-toolkit/blob/master/LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
6060

6161
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.

buildspec-gputests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ version: 0.2
22

33
env:
44
variables:
5-
FRAMEWORK_VERSION: '1.6.0'
6-
GPU_INSTANCE_TYPE: 'ml.p2.8xlarge'
5+
FRAMEWORK_VERSION: '1.11.0'
6+
GPU_INSTANCE_TYPE: 'ml.p3.8xlarge'
77
ECR_REPO: 'sagemaker-test'
88
GITHUB_REPO: 'sagemaker-pytorch-container'
99
DLC_ACCOUNT: '763104351884'

buildspec-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ phases:
1212
# run unit tests
1313
- AWS_ACCESS_KEY_ID= AWS_SECRET_ACCESS_KEY= AWS_SESSION_TOKEN=
1414
AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION=
15-
tox -e py27,py36,py37 -- test/unit
15+
tox -e py37,py38 -- test/unit
1616

1717
# run local integ tests
1818
#- $(aws ecr get-login --no-include-email --region us-west-2)

buildspec-unittests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ phases:
1313
- tox -e flake8,twine
1414

1515
# run unit tests
16-
- tox -e py27,py36,py37 test/unit
16+
- tox -e py37,py38 test/unit

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ def read(fname):
4848
"Natural Language :: English",
4949
"License :: OSI Approved :: Apache Software License",
5050
"Programming Language :: Python",
51-
'Programming Language :: Python :: 2.7',
52-
'Programming Language :: Python :: 3.6',
5351
'Programming Language :: Python :: 3.7',
52+
'Programming Language :: Python :: 3.8',
53+
'Programming Language :: Python :: 3.9',
5454
],
5555

56-
install_requires=['retrying', 'sagemaker-training>=3.7.0', 'six>=1.12.0'],
56+
install_requires=['retrying', 'sagemaker-training>=4.2.0', 'six>=1.12.0'],
5757
extras_require={
5858
'test': test_dependencies
5959
},

test/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ def pytest_addoption(parser):
4646
parser.addoption('--build-image', '-B', action='store_true')
4747
parser.addoption('--push-image', '-P', action='store_true')
4848
parser.addoption('--dockerfile-type', '-T', choices=['dlc.cpu', 'dlc.gpu', 'pytorch'],
49-
default=None)
49+
default='pytorch')
5050
parser.addoption('--dockerfile', '-D', default=None)
5151
parser.addoption('--aws-id', default=None)
5252
parser.addoption('--instance-type')
5353
parser.addoption('--docker-base-name', default='sagemaker-pytorch-training')
5454
parser.addoption('--region', default='us-west-2')
55-
parser.addoption('--framework-version', default="1.4.0")
55+
parser.addoption('--framework-version', default="1.10.0")
5656
parser.addoption('--py-version', choices=['2', '3'], default=str(sys.version_info.major))
5757
parser.addoption('--processor', choices=['gpu', 'cpu'], default='cpu')
5858
# If not specified, will default to {framework-version}-{processor}-py{py-version}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
ARG region
2+
from 763104351884.dkr.ecr.$region.amazonaws.com/pytorch-training:1.6.0-cpu-py36-ubuntu16.04
3+
4+
COPY lib/changehostname.c /
5+
COPY lib/start_with_right_hostname.sh /usr/local/bin/start_with_right_hostname.sh
6+
RUN chmod +x /usr/local/bin/start_with_right_hostname.sh
7+
8+
COPY dist/sagemaker_pytorch_training-*.tar.gz /sagemaker_pytorch_training.tar.gz
9+
RUN pip install --upgrade --no-cache-dir /sagemaker_pytorch_training.tar.gz && \
10+
rm /sagemaker_pytorch_training.tar.gz
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
ARG region
2+
FROM 763104351884.dkr.ecr.$region.amazonaws.com/pytorch-training:1.11.0-gpu-py38-cu113-ubuntu20.04-sagemaker
3+
4+
COPY dist/sagemaker_pytorch_training-*.tar.gz /sagemaker_pytorch_training.tar.gz
5+
RUN pip install --upgrade --no-cache-dir /sagemaker_pytorch_training.tar.gz && \
6+
rm /sagemaker_pytorch_training.tar.gz
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
FROM pytorch/pytorch:1.11.0-cuda11.3-cudnn8-runtime
2+
3+
RUN apt-get update && apt-get install -y --no-install-recommends \
4+
jq \
5+
build-essential \
6+
cmake \
7+
gcc
8+
RUN rm -rf /var/lib/apt/lists/*
9+
10+
COPY lib/changehostname.c /
11+
COPY lib/start_with_right_hostname.sh /usr/local/bin/start_with_right_hostname.sh
12+
RUN chmod +x /usr/local/bin/start_with_right_hostname.sh
13+
14+
COPY dist/sagemaker_pytorch_training-*.tar.gz /sagemaker_pytorch_training.tar.gz
15+
RUN pip install --no-cache-dir /sagemaker_pytorch_training.tar.gz && \
16+
rm /sagemaker_pytorch_training.tar.gz
17+
18+
ENV SAGEMAKER_TRAINING_MODULE=sagemaker_pytorch_container.training:main
19+
20+
WORKDIR /
21+
22+
# Starts framework
23+
ENTRYPOINT ["bash", "-m", "start_with_right_hostname.sh"]

test/container/1.6.0/Dockerfile.dlc.cpu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
ARG region
2-
from 763104351884.dkr.ecr.$region.amazonaws.com/pytorch-training:1.6.0-cpu-py36-ubuntu16.04
2+
FROM 763104351884.dkr.ecr.$region.amazonaws.com/pytorch-training:1.11.0-cpu-py38-ubuntu20.04-sagemaker
33

44
COPY lib/changehostname.c /
55
COPY lib/start_with_right_hostname.sh /usr/local/bin/start_with_right_hostname.sh

0 commit comments

Comments
 (0)