Skip to content

Conversation

@txhsl
Copy link
Contributor

@txhsl txhsl commented May 29, 2024

Close #197.

@AnnaShaleva AnnaShaleva self-requested a review May 29, 2024 16:44
@txhsl txhsl force-pushed the governance-candidate-limit branch from 02045ee to 5c42ebf Compare May 30, 2024 09:19
@txhsl
Copy link
Contributor Author

txhsl commented May 30, 2024

The commit history seems a mess. :(

But the code is now rebased to master branch and ready for review.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a straightforward API.

@AnnaShaleva
Copy link
Member

The commit history seems a mess. :(

Just squash all of them and a add a pretty commit message, it will solve the problem!

@steven1227 steven1227 requested a review from shargon June 7, 2024 09:20
@txhsl txhsl merged commit 7017f7a into bane-main Jun 13, 2024
@txhsl txhsl deleted the governance-candidate-limit branch June 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GVN-01 - High Resource Consumption in candidateList [High]

4 participants