systemcontract: apply blacklist policy to governance election #242
Conversation
|
With this policy check, the total gas cost of |
I think we'd better increase the syscall GAS limit. |
txhsl
force-pushed
the
governance-blacklist-check
branch
2 times, most recently
from
30499bf to
e753b75
Compare
|
@AnnaShaleva OK, now I have a good new idea to apply blacklist. |
txhsl
force-pushed
the
governance-blacklist-check
branch
from
e753b75 to
a88db31
Compare
txhsl
force-pushed
the
governance-blacklist-check
branch
from
a88db31 to
448d885
Compare
txhsl
force-pushed
the
governance-blacklist-check
branch
2 times, most recently
from
d56de4b to
6819c4c
Compare
txhsl
force-pushed
the
governance-blacklist-check
branch
from
6819c4c to
080c45a
Compare
| if (receivedVotes[candidate] > 0) { | ||
| totalVotes += receivedVotes[candidate]; | ||
| } | ||
| emit Activate(candidate); |
There was a problem hiding this comment.
And just a minor note: if now we use a single notification for both usual registration and activation, then probably "Registered" is more preferable than "Activate"? Because in 99% cases it's a usual candidate registration, so users may be confused by receiving "Activate" notification rather than "Registered".
| function deactivateCandidate(address candidate) external { | ||
| if (msg.sender != POLICY) revert Errors.SideCallNotAllowed(); | ||
| if (_deactivateCandidate(candidate)) blacklistedCandidates += 1; | ||
| } |
There was a problem hiding this comment.
And a final note regarding blocked accounts: suppose candidate is in the list and is currently a CN. Once committee blocks this account, then this candidate won't be kicked off from the CN list immediately, instead it will remain there until the next epoch. We have a similar bug in NeoGo (nspcc-dev/neo-go#3449), and C# node handles this situation properly.
We may create an issue to handle that in future.
Close #239. Testing with 2000
candidateLimit...