Add option (fullText) for back compatible #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If fullText no set (default behavior), Sha-1 calculated from dependencies and devDependencies from package.json If fullText is set, Sha-1 calculated from full text of package.json. Which is back compatible with v3.3.0 and before.
| // compute a hash based on the stable-stringified contents of package.json | ||
| // (`packageJsonContent` might differ on different platforms, depending on line endings etc.) | ||
| let stableContent = stringify([packageJson.dependencies, packageJson.devDependencies]); | ||
| if (fullText === true) { |
Owner
There was a problem hiding this comment.
For consistency with other places better if (fullText) {
Owner
|
Thanks, @liangyulai, very much appreciated. |
Owner
|
Implemented in #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fullText no set (default behavior), Sha-1 calculated from
dependencies and devDependencies from package.json
If fullText is set, Sha-1 calculated from
full text of package.json. Which is back compatible
with v3.3.0 and before.