Skip to content

Commit c1c040c

Browse files
committed
fix(common): CHECKOUT-6832 Fix types and optionals
1 parent 2abee20 commit c1c040c

File tree

3 files changed

+21
-19
lines changed

3 files changed

+21
-19
lines changed

packages/core/src/app/customer/LoginForm.tsx

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -131,23 +131,25 @@ const LoginForm: FunctionComponent<
131131
<PasswordField />
132132

133133
<p className="form-legend-container">
134-
{isSignInEmailEnabled && (
135-
<TranslatedLink
136-
id="login_email.link"
137-
onClick={onSendLoginEmail}
138-
testId="customer-signin-link"
139-
/>
140-
)}
141-
{!isSignInEmailEnabled && (
142-
<a
143-
data-test="forgot-password-link"
144-
href={forgotPasswordUrl}
145-
rel="noopener noreferrer"
146-
target="_blank"
147-
>
148-
<TranslatedString id="customer.forgot_password_action" />
149-
</a>
150-
)}
134+
<span>
135+
{isSignInEmailEnabled && (
136+
<TranslatedLink
137+
id="login_email.link"
138+
onClick={onSendLoginEmail}
139+
testId="customer-signin-link"
140+
/>
141+
)}
142+
{!isSignInEmailEnabled && (
143+
<a
144+
data-test="forgot-password-link"
145+
href={forgotPasswordUrl}
146+
rel="noopener noreferrer"
147+
target="_blank"
148+
>
149+
<TranslatedString id="customer.forgot_password_action" />
150+
</a>
151+
)}
152+
</span>
151153
{viewType === CustomerViewType.Login && shouldShowCreateAccountLink && (
152154
<span>
153155
<TranslatedLink

packages/payment-integration-test-framework/src/fixture/pageObject/playwright/PollyObject.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class PollyObject {
9292
}
9393

9494
stop(): Promise<void> | undefined {
95-
return this.polly && this.polly.stop();
95+
return this.polly?.stop();
9696
}
9797

9898
enableRecord(): void {

packages/payment-integration-test-framework/src/fixture/pageObject/playwright/ServerSideRender.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import ejs from 'ejs';
44
* @internal
55
*/
66
export class ServerSideRender {
7-
async renderFile(filePath: string, data?: Record<string, unknown>): Promise<string> {
7+
renderFile(filePath: string, data?: Record<string, unknown>): Promise<string> {
88
return ejs.renderFile(filePath, data);
99
}
1010
}

0 commit comments

Comments
 (0)