feat(payment): INT-6675 [Digital River] Update billingAddress from paypal #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-alejandroRodriguez
force-pushed
the
INT-6675
branch
3 times, most recently
from
e748491 to
4f61557
Compare
bc-alejandroRodriguez
force-pushed
the
INT-6675
branch
2 times, most recently
from
d2fc30b to
d4fe35d
Compare
clopezh
approved these changes
Oct 12, 2022
Contributor
clopezh
left a comment
clopezh
left a comment
There was a problem hiding this comment.
Great work @bc-alejandroRodriguez ! General LGTM! I only have one comment that I'll appreciate if you attend it!
👍🏻 ✅
packages/core/src/payment/strategies/digitalriver/digitalriver-payment-strategy.ts
Outdated
Show resolved
Hide resolved
bc-alejandroRodriguez
force-pushed
the
INT-6675
branch
from
d4fe35d to
14fe46c
Compare
|
💚 Tested! QE Details. Following scenarios were tested:
Pending test due to Tax Application (Avalara tax app) roadblock:
Please review attached word file with validation details. |
bc-peng
reviewed
Oct 20, 2022
packages/core/src/payment/strategies/digitalriver/digitalriver-payment-strategy.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/src/payment/strategies/digitalriver/digitalriver-payment-strategy.ts
Show resolved
Hide resolved
bc-alejandroRodriguez
changed the title
bc-peng
approved these changes
Oct 20, 2022
Contributor
bc-peng
left a comment
bc-peng
left a comment
There was a problem hiding this comment.
LGTM, please address some minor areas before merging. Thanks.
packages/core/src/payment/strategies/digitalriver/digitalriver-payment-strategy.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/src/payment/strategies/digitalriver/digitalriver-payment-strategy.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/src/payment/strategies/digitalriver/digitalriver-payment-strategy.ts
Outdated
Show resolved
Hide resolved
bc-alejandroRodriguez
force-pushed
the
INT-6675
branch
from
496a07e to
e07829e
Compare
bc-alejandroRodriguez
force-pushed
the
INT-6675
branch
from
e07829e to
da798ad
Compare
bc-alejandroRodriguez
added
reviewed
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Support PayPal as APM for Digital River
Why?
As a merchant using Digital River, I want to be able to accept payment with PayPal.
AC:
When enabled on Digital River account, PayPal displays within the DR drop-in component on my checkout page.
Shopper can pay with PayPal.
Merchant can void PayPal transaction from CP.
Merchant can capture PayPal transaction from CP.
Merchant can fully refund PayPal transaction from CP.
Merchant can partially refund PayPal transaction from CP.
reflect the correct billing address on the order in BC (if Paypal address is different from what was entered on the checkout form)
For a digital order , the tax must be calculated based on the billing address on the PayPal account
Testing / Proof
Screen.Recording.2022-10-10.at.17.06.20.mov
@bigcommerce/checkout @bigcommerce/payments @bigcommerce/apex-integrations