netinfo: return local services in the default report

Credit to l0rinc for refactoring ServicesList().

Co-authored-by: l0rinc <[email protected]>

Github-Pull: bitcoin#31886
Rebased-From: fb9b118

Author: jonatack

src/bitcoin-cli.cpp

@@ -481,6 +481,17 @@ class NetinfoRequestHandler : public BaseRequestHandler
         }
         return str;
     }
+    static std::string ServicesList(const UniValue& services)
+    {
+        std::string str{services.size() ? services[0].get_str() : ""};
+        for (size_t i{1}; i < services.size(); ++i) {
+            str += ", " + services[i].get_str();
+        }
+        for (auto& c: str) {
+            c = (c == '_' ? ' ' : ToLower(c));
+        }
+        return str;
+    }
 
 public:
     static constexpr int ID_PEERINFO = 0;
@@ -654,6 +665,7 @@ class NetinfoRequestHandler : public BaseRequestHandler
         }
 
         // Report local addresses, ports, and scores.
+        result += strprintf("\n\nLocal services: %s", ServicesList(networkinfo["localservicesnames"]));
         result += "\n\nLocal addresses";
         const std::vector<UniValue>& local_addrs{networkinfo["localaddresses"].getValues()};
         if (local_addrs.empty()) {