remove unused method

Author: paulomach

src/relations/mysql_provider.py

@@ -20,7 +20,7 @@
 )
 from ops.charm import RelationBrokenEvent, RelationDepartedEvent, RelationJoinedEvent
 from ops.framework import Object
-from ops.model import BlockedStatus, Relation, Unit
+from ops.model import BlockedStatus, Relation
 
 from constants import DB_RELATION_NAME, PASSWORD_LENGTH, PEER
 from utils import generate_random_password
@@ -311,45 +311,3 @@ def _on_database_provides_relation_departed(self, event: RelationDepartedEvent)
             logger.info(f"Removed router from metadata {user.router_id}")
         except MySQLRemoveRouterFromMetadataError:
             logger.error(f"Failed to remove router from metadata with ID {user.router_id}")
-
-    def remove_unit_from_endpoints(self, unit: Unit) -> None:
-        """Remove a unit from the endpoints for related applications.
-
-        Args:
-            unit (ops.Unit): The the unit to be removed.
-        """
-        if not self.charm.unit.is_leader():
-            return
-
-        if not self.charm.cluster_initialized:
-            logger.debug("Waiting cluster to be initialized")
-            return
-
-        unit_address = self.charm.get_unit_ip(unit)
-
-        # filter out the unit address from the (ro)endpoints
-        for relation in self.active_relations:
-            # rw endpoints
-            endpoints = (
-                self.database.fetch_my_relation_field(relation.id, "endpoints", DB_RELATION_NAME)
-                or ""
-            )
-            if unit_address in endpoints:
-                self.database.set_endpoints(
-                    relation.id,
-                    ",".join([e for e in endpoints.split(",") if unit_address not in e]),
-                )
-                continue
-
-            # ro endpoints
-            ro_endpoints = (
-                self.database.fetch_my_relation_field(
-                    relation.id, "read-only-endpoints", DB_RELATION_NAME
-                )
-                or ""
-            )
-            if unit_address in ro_endpoints:
-                self.database.set_read_only_endpoints(
-                    relation.id,
-                    ",".join([e for e in ro_endpoints.split(",") if unit_address not in e]),
-                )

tests/unit/test_database.py

@@ -103,34 +103,3 @@ def test_relation_departed(
         self.harness.remove_relation(self.database_relation_id)
         _delete_user.assert_called_once_with("user1")
         _remove_router.assert_called_once_with("router_id")
-
-    def test_remove_unit_from_endpoints(self):
-        self.harness.set_leader(True)
-        self.charm.on.config_changed.emit()
-        self.harness.update_relation_data(
-            self.peer_relation_id, self.charm.app.name, {"units-added-to-cluster": "1"}
-        )
-
-        self.harness.update_relation_data(
-            self.database_relation_id,
-            self.charm.app.name,
-            {
-                "data": '{"database": "test_db"}',
-                "password": "super_secure_password",
-                "username": f"relation-{self.database_relation_id}",
-                "endpoints": "2.2.2.2:3306",
-                "version": "8.0.36-0ubuntu0.22.04.3",
-                "database": "test_db",
-                "read-only-endpoints": "2.2.2.1:3306",
-            },
-        )
-
-        remove_unit = self.harness.model.get_unit("mysql/1")
-        with patch("charm.MySQLOperatorCharm.get_unit_ip", return_value="2.2.2.1"):
-            self.charm.database_relation.remove_unit_from_endpoints(remove_unit)
-
-        relation_data = self.harness.get_relation_data(
-            self.database_relation_id, self.charm.app.name
-        )
-
-        self.assertNotIn("read-only-endpoints", relation_data.keys())