From 0216d99235650fa13df304cf097d2ee10ec02750 Mon Sep 17 00:00:00 2001 From: Rahul Lakade Date: Mon, 29 Jul 2019 12:59:06 +0530 Subject: [PATCH 1/2] Updated document to use goog:chromeOptions (#757) --- docs/introduction/command-line-runner.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/introduction/command-line-runner.md b/docs/introduction/command-line-runner.md index 19c1a087a5..16b595e8f1 100644 --- a/docs/introduction/command-line-runner.md +++ b/docs/introduction/command-line-runner.md @@ -135,13 +135,13 @@ The runner will automatically set the number of workers to the same number of CP If you have Chrome installed in a non-standard location on your machine you can specify the path so ChromeDriver knows where to look. ```sh -selenium-side-runner -c "chromeOptions.binary='/path/to/non-standard/Chrome/install'" +selenium-side-runner -c "goog:chromeOptions.binary='/path/to/non-standard/Chrome/install'" ``` With Chrome specific capabilities you can also run the tests headlessly. ```sh -selenium-side-runner -c "chromeOptions.args=[disable-infobars, headless]" +selenium-side-runner -c "goog:chromeOptions.args=[disable-infobars, headless]" ``` ## A framework at your fingertips From 848d0409eeadf99c71d12a0e0c1e34d89d47d65e Mon Sep 17 00:00:00 2001 From: cdifino Date: Thu, 1 Aug 2019 01:01:10 -0700 Subject: [PATCH 2/2] Bug fix: Foreach command in selenium-side-runner (#752) * Fixed side-runner foreach command * Fixed Test for foreach in Selianize Fixed the for each test. --- packages/selianize/__tests__/command.spec.js | 2 +- packages/selianize/src/command.js | 4 ++-- packages/selianize/yarn.lock | 4 ---- packages/side-utils/yarn.lock | 5 ----- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/packages/selianize/__tests__/command.spec.js b/packages/selianize/__tests__/command.spec.js index a58fe01ba2..a12af63b3d 100644 --- a/packages/selianize/__tests__/command.spec.js +++ b/packages/selianize/__tests__/command.spec.js @@ -1163,7 +1163,7 @@ describe('command code emitter', () => { value: 'iterator', } return expect(CommandEmitter.emit(command)).resolves.toBe( - `for (let i = 0; i < vars["collection"].length - 1; i++) {vars["iterator"] = vars["collection"][i];` + `for (let i = 0; i < vars["collection"].length; i++) {vars["iterator"] = vars["collection"][i];` ) }) it('should emit `assert` command', () => { diff --git a/packages/selianize/src/command.js b/packages/selianize/src/command.js index 59bbeb721b..75b28ed8bc 100644 --- a/packages/selianize/src/command.js +++ b/packages/selianize/src/command.js @@ -1,4 +1,4 @@ -// Licensed to the Software Freedom Conservancy (SFC) under one +// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file @@ -802,7 +802,7 @@ function emitControlFlowWhile(target) { function emitControlFlowForEach(collectionVarName, iteratorVarName) { return Promise.resolve( - `for (let i = 0; i < vars["${collectionVarName}"].length - 1; i++) {vars["${iteratorVarName}"] = vars["${collectionVarName}"][i];` + `for (let i = 0; i < vars["${collectionVarName}"].length; i++) {vars["${iteratorVarName}"] = vars["${collectionVarName}"][i];` ) } diff --git a/packages/selianize/yarn.lock b/packages/selianize/yarn.lock index 4609872fe5..1f87357563 100644 --- a/packages/selianize/yarn.lock +++ b/packages/selianize/yarn.lock @@ -1127,10 +1127,6 @@ js-levenshtein@^1.1.3: resolved "https://registry.yarnpkg.com/js-levenshtein/-/js-levenshtein-1.1.6.tgz#c6cee58eb3550372df8deb85fad5ce66ce01d59d" integrity sha512-X2BB11YZtrRqY4EnQcLX5Rh373zbK4alC1FW7D7MBhL2gtcC17cTnr6DmfHZeS0s2rTHjUTMMHfG7gO8SSdw+g== -js-string-escape@^1.0.1: - version "1.0.1" - resolved "https://registry.yarnpkg.com/js-string-escape/-/js-string-escape-1.0.1.tgz#e2625badbc0d67c7533e9edc1068c587ae4137ef" - "js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0: version "4.0.0" resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499" diff --git a/packages/side-utils/yarn.lock b/packages/side-utils/yarn.lock index 68e5079872..f31289d921 100644 --- a/packages/side-utils/yarn.lock +++ b/packages/side-utils/yarn.lock @@ -1327,11 +1327,6 @@ js-levenshtein@^1.1.3: resolved "https://registry.yarnpkg.com/js-levenshtein/-/js-levenshtein-1.1.6.tgz#c6cee58eb3550372df8deb85fad5ce66ce01d59d" integrity sha512-X2BB11YZtrRqY4EnQcLX5Rh373zbK4alC1FW7D7MBhL2gtcC17cTnr6DmfHZeS0s2rTHjUTMMHfG7gO8SSdw+g== -js-string-escape@^1.0.1: - version "1.0.1" - resolved "https://registry.yarnpkg.com/js-string-escape/-/js-string-escape-1.0.1.tgz#e2625badbc0d67c7533e9edc1068c587ae4137ef" - integrity sha1-4mJbrbwNZ8dTPp7cEGjFh65BN+8= - "js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0: version "4.0.0" resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"