handle req.query mutations for express 5

carmine · carmine · commit 1d69d8a67031 · 2024-12-27T20:19:17.000-05:00
diff --git a/src/middlewares/openapi.request.validator.ts b/src/middlewares/openapi.request.validator.ts
@@ -139,6 +139,7 @@ export class RequestValidator {
         }
         req.params = openapi.pathParams ?? req.params;
       }
+
       // HACK for express 5, temporarily make req.query mutable
       const reqQueryDescriptor = Object.getOwnPropertyDescriptor(req, 'query');
       Object.defineProperty(req, 'query', {
@@ -166,7 +167,6 @@ export class RequestValidator {
       // HACK for express 5, Restore the original descriptor
       if (reqQueryDescriptor) {
           Object.defineProperty(req, 'query', reqQueryDescriptor);
-          console.log('Query property restored to original descriptor.');
       }
 
       const cookies = req.cookies

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,7 @@ export class RequestValidator {`
`139`	`139`	`}`
`140`	`140`	`req.params = openapi.pathParams ?? req.params;`
`141`	`141`	`}`
	`142`	`+`
`142`	`143`	`// HACK for express 5, temporarily make req.query mutable`
`143`	`144`	`const reqQueryDescriptor = Object.getOwnPropertyDescriptor(req, 'query');`
`144`	`145`	`Object.defineProperty(req, 'query', {`
`@@ -166,7 +167,6 @@ export class RequestValidator {`
`166`	`167`	`// HACK for express 5, Restore the original descriptor`
`167`	`168`	`if (reqQueryDescriptor) {`
`168`	`169`	`Object.defineProperty(req, 'query', reqQueryDescriptor);`
`169`		`- console.log('Query property restored to original descriptor.');`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`const cookies = req.cookies`