fix tests for node 24

Author: cdimascio

test/881.spec.ts

@@ -1,16 +1,20 @@
 import { expect } from 'chai';
 import * as request from 'supertest';
+import * as  express from 'express';
+import * as path from 'path';
+import * as http from 'http';
+import * as OpenApiValidator from '../src';
 
 describe('multi-spec', () => {
-  let app = null;
+  let app: any = null;
 
   before(async () => {
     // Set up the express app
     app = createServer();
   });
 
   after(() => {
-    app.server.close();
+    if (app && app.server) (app as any).server.close();
   });
 
   it('create campaign should return 200', async () =>
@@ -32,11 +36,6 @@ describe('multi-spec', () => {
 });
 
 function createServer() {
-  const express = require('express');
-  const path = require('path');
-  const http = require('http');
-  const OpenApiValidator = require('../src');
-
   const app = express();
   app.use(express.urlencoded({ extended: false }));
   app.use(express.text());
@@ -116,6 +115,6 @@ function createServer() {
     });
   }
 
-  app.server = server;
+  (app as any).server = server;
   return app;
 }

test/common/app.mw.ts

@@ -15,7 +15,7 @@ export async function createApp(
   apiRouter = undefined,
 ) {
   var app = express();
-  (<any>app).basePath = '/v1';
+  (app as any).basePath = '/v1';
 
   app.use(express.json());
   app.use(express.json({ type: 'application/*+json' }));

test/default.export.fn.spec.ts

@@ -4,15 +4,17 @@ import { expect } from 'chai';
 import * as request from 'supertest';
 import * as path from 'path';
 import {OpenAPIV3} from "../src/framework/types";
+import { Server } from 'http';
 
 describe('default export resolver', () => {
-  let server = null;
+  let server: Server;
   let app = express();
 
+
   before(async () => {
     app.use(
       OpenApiValidator.middleware({
-        apiSpec: <OpenAPIV3.DocumentV3>{
+        apiSpec: {
           openapi: '3.0.0',
           info: { version: '1.0.0', title: 'test bug OpenApiValidator' },
           paths: {
@@ -25,7 +27,7 @@ describe('default export resolver', () => {
               }
             },
           },
-        },
+        } as OpenAPIV3.DocumentV3,
         operationHandlers: path.join(__dirname, 'resources'),
       }),
     );

test/headers.spec.ts

@@ -3,9 +3,10 @@ import { expect } from 'chai';
 import * as request from 'supertest';
 import { createApp } from './common/app';
 import * as packageJson from '../package.json';
+import { AppWithServer } from './common/app.common';
 
 describe(packageJson.name, () => {
-  let app = null;
+  let app: AppWithServer;
 
   /**
    * Required to create app for each step, since 'buildMiddleware' is cached by media-type in contentType.
@@ -22,7 +23,7 @@ describe(packageJson.name, () => {
   });
 
   afterEach(() => {
-    (<any>app).server.close();
+    app.server.close();
   });
 
   it('should throw 400 if required header is missing', async () =>

test/invalid.apispec.spec.ts

@@ -12,7 +12,7 @@ describe('invalid api spec', () => {
       apiSpec,
     });
     await request(app).get('/dev/hello/echo').expect(500);
-    app.server.close();
+    app.server!.close();
   });
   it('should fail gracefully when validateApiSpec is false', async () => {
     const apiSpec = createApiSpec();
@@ -21,7 +21,7 @@ describe('invalid api spec', () => {
       validateApiSpec: false,
     });
     await request(app).get('/dev/hello/echo').expect(500);
-    app.server.close();
+    app.server!.close();
   });
 });
 
@@ -32,17 +32,19 @@ async function createApp(
 
   app.use(OpenApiValidator.middleware(opts));
   app.use(
-    express.Router().get('/dev/hello/echo', (req, res) => {
-      res.status(200).send((<any>req.params).value);
-    }),
+    express
+      .Router()
+      .get('/dev/hello/echo', (req: express.Request, res: express.Response) => {
+        res.status(200).send(req.params.value);
+      }),
   );
 
   await startServer(app, 3001);
   return app;
 }
 
 function createApiSpec(): OpenAPIV3.DocumentV3 {
-  return <any>{
+  return {
     openapi: '3.0.3',
     info: {
       title: 'The API',
@@ -69,7 +71,7 @@ function createApiSpec(): OpenAPIV3.DocumentV3 {
           summary: 'Responds with the request.',
           description: '',
           responses: { '200': { description: 'OK' } },
-          parameters: { q: 'string' }, // <-- THE INCORRECT BIT
+          parameters: { q: 'string' } as any, // <-- THE INCORRECT BIT
           tags: ['dev/hello'],
         },
       },

test/multi.spec.spec.ts

@@ -1,16 +1,20 @@
 import { expect } from 'chai';
 import * as request from 'supertest';
+import * as express from 'express';
+import * as path from 'path';
+import * as http from 'http';
+import * as OpenApiValidator from '../src';
 
 describe('multi-spec', () => {
-  let app = null;
+  let app: any = null;
 
   before(async () => {
     // Set up the express app
     app = createServer();
   });
 
   after(() => {
-    app.server.close();
+    if (app && app.server) (app as any).server.close();
   });
 
   it('create campaign should return 200', async () =>
@@ -32,11 +36,6 @@ describe('multi-spec', () => {
 });
 
 function createServer() {
-  const express = require('express');
-  const path = require('path');  
-  const http = require('http');
-  const OpenApiValidator = require('../src');
-
   const app = express();
   app.use(express.urlencoded({ extended: false }));
   app.use(express.text());
@@ -115,6 +114,6 @@ function createServer() {
     });
   }
 
-  app.server = server;
+  (app as any).server = server;
   return app;
 }

test/multipart.disabled.spec.ts

@@ -37,7 +37,7 @@ describe(packageJson.name, () => {
     );
   });
   after(() => {
-    (<any>app).server.close();
+    app.server.close();
   });
   describe(`multipart disabled`, () => {
     it('should throw 400 when required multipart file field', async () =>

test/multipart.spec.ts

@@ -44,7 +44,7 @@ describe('a multipart request', () => {
     fileNames.length = 0;
   });
   after(() => {
-    (<any>app).server.close();
+    app.server.close();
   });
 
   describe('that contains $refs', () => {
@@ -129,7 +129,7 @@ describe('a multipart request', () => {
 
       const imgStream = fs.createReadStream(testImage);
       imgStream.on('end', () => req.end(done));
-      imgStream.pipe(<any>req, { end: false });
+      imgStream.pipe(req as any, { end: false });
     });
 
     it('should validate multipart file and metadata', async () => {
@@ -162,7 +162,7 @@ describe('when request does not use parsers', () => {
   let app;
 
   after(() => {
-    (<any>app).server.close();
+    app.server.close();
   });
 
   before(async () => {

test/openapi.spec.ts

@@ -3,10 +3,11 @@ import { expect } from 'chai';
 import * as request from 'supertest';
 import { createApp } from './common/app';
 import * as packageJson from '../package.json';
+import { AppWithServer } from './common/app.common';
 
 describe(packageJson.name, () => {
-  const apps = [];
-  let basePath = null;
+  const apps: AppWithServer[] = [];
+  let basePath;
 
   before(() => {
     const apiSpecPath = path.join('test', 'resources', 'openapi.yaml');
@@ -33,7 +34,7 @@ describe(packageJson.name, () => {
     ]).then(([a1, a2]) => {
       apps.push(a1);
       apps.push(a2);
-      basePath = (<any>a1).basePath;
+      basePath = a1.basePath;
     });
   });
 

test/operation.handler.spec.ts

@@ -7,6 +7,7 @@ import * as resolvers from '../src/resolvers';
 import { createApp } from './common/app';
 import { OpenApiValidatorOpts } from '../src/framework/types';
 import * as pkg from '../package.json';
+import { AppWithServer } from './common/app.common';
 
 const expressVersion = pkg.devDependencies.express;
 
@@ -20,7 +21,7 @@ describe('operation handler', () => {
     const mwf = OpenApiValidator.middleware;
     app.use(mwf({ apiSpec }));
 
-    expect((<any>mwf)._oav)
+    expect((mwf as any)._oav)
       .to.have.property('options')
       .to.deep.include({ operationHandlers: false });
 
@@ -38,7 +39,7 @@ describe('operation handler', () => {
     const mwf = OpenApiValidator.middleware;
     app.use(mwf({ apiSpec }));
 
-    expect((<any>mwf)._oav)
+    expect((mwf as any)._oav)
       .to.have.property('options')
       .to.deep.include({ operationHandlers: false });
   });
@@ -55,7 +56,7 @@ describe('operation handler', () => {
 
     app.use(oav);
 
-    expect((<any>mwf)._oav)
+    expect((mwf as any)._oav)
       .to.have.property('options')
       .to.deep.include({
         operationHandlers: {
@@ -87,7 +88,7 @@ describe('operation handler', () => {
 
     app.use(oav);
 
-    expect((<any>mwf)._oav)
+    expect((mwf as any)._oav)
       .to.have.property('options')
       .to.deep.include({ operationHandlers: handler });
 
@@ -96,8 +97,8 @@ describe('operation handler', () => {
 });
 
 describe('custom operation handler', () => {
-  let app = null;
-  let basePath = null;
+  let app: AppWithServer;
+  let basePath;
   const apiSpec = path.join(
     __dirname,
     'resources/eov-operations.modulepath.yaml',