-
Notifications
You must be signed in to change notification settings - Fork 2
Testnet v1.4.8 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testnet v1.4.8 #73
Changes from all commits
3f43e43
872e82c
07c6d61
5f8a9fa
c9c437a
2a96edb
642cb37
b55fd6e
c66865c
03112b3
f25030f
5fd9b1d
16b3a72
a7487df
34ab340
40efcbb
bb386ed
da8feb8
21fbbfa
bba7f63
36c68e5
0301b54
7b9e517
fb63205
cf3423a
5f5899b
473ce79
12ac4c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,13 +1,15 @@ | ||||||
| FROM debian:bullseye-slim | ||||||
| FROM debian:bullseye-slim@sha256:34b63f55a4b193ad03c5ddb4b3f8546c797763ed708f0df5309ecb9507d15179 | ||||||
|
|
||||||
| RUN adduser --disabled-password --gecos "" --no-create-home --uid 1000 cronos | ||||||
|
|
||||||
| RUN mkdir -p /home/cronos/data && mkdir -p /home/cronos/config | ||||||
| RUN apt-get update -y && apt-get install wget curl procps net-tools jq lz4 -y | ||||||
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v0.8.1/cronos_0.8.1_Linux_x86_64.tar.gz && tar -xvf cronos_0.8.1_Linux_x86_64.tar.gz \ | ||||||
| && rm cronos_0.8.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/ | ||||||
|
|
||||||
| RUN cd /home/cronos && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.4.8/cronos_1.4.8-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.4.8-testnet_Linux_x86_64.tar.gz \ | ||||||
| && rm cronos_1.4.8-testnet_Linux_x86_64.tar.gz | ||||||
|
|
||||||
| RUN chown -R cronos:cronos /home/cronos | ||||||
|
|
||||||
| USER cronos | ||||||
|
|
||||||
| ENTRYPOINT ["/home/cronos/bin/cronosd"] | ||||||
| ENTRYPOINT ["/home/cronos/bin/cronosd"] | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After the extraction step you do not move the files, so the binary likely resides at Please either:
-ENTRYPOINT ["/home/cronos/bin/cronosd"]
+ENTRYPOINT ["/home/cronos/cronos_1.4.8-testnet_Linux_x86_64/bin/cronosd"]
Without this fix the image will exit with “file not found”. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove
--no-check-certificateand add integrity checks for the binary downloadDisabling TLS validation (
--no-check-certificate) opens the build to MITM attacks.At a minimum, keep certificate verification enabled and verify the tarball’s checksum:
This keeps TLS verification, checks the archive hash, flattens the directory (
--strip-components=1) and cleans up in a single layer.📝 Committable suggestion
🧰 Tools
🪛 Checkov (3.2.334)
[HIGH] 8-9: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
🤖 Prompt for AI Agents