Merge pull request #12 from chrisw-dev/check-encoding

check and handle errors around encoding

Author: chrisw-dev

internal/handlers/token.go

@@ -55,7 +55,9 @@ func (h *TokenHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 			errorResponse["error_description"] = errorScenario.Description
 		}
 
-		json.NewEncoder(w).Encode(errorResponse)
+		if err := json.NewEncoder(w).Encode(errorResponse); err != nil {
+			log.Printf("Error encoding error response: %v", err)
+		}
 		return
 	}
 

internal/handlers/userinfo.go

@@ -25,15 +25,17 @@ func (h *UserInfoHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(errorScenario.StatusCode)
 
 		errorResponse := map[string]string{
-			"error": errorScenario.ErrorCode,
-		}
-		
-		if errorScenario.Description != "" {
-			errorResponse["error_description"] = errorScenario.Description
-		}
-		
-		json.NewEncoder(w).Encode(errorResponse)
-		return
+		"error": errorScenario.ErrorCode,
+	}
+	
+	if errorScenario.Description != "" {
+		errorResponse["error_description"] = errorScenario.Description
+	}
+	
+	if err := json.NewEncoder(w).Encode(errorResponse); err != nil {
+		log.Printf("Error encoding error response: %v", err)
+	}
+	return
 	}
 
 	authHeader := r.Header.Get("Authorization")

test/integration/oauth_flow_test.go

@@ -428,7 +428,9 @@ func TestUserInfoEndpointErrorScenario(t *testing.T) {
 	defer tokenResp.Body.Close()
 
 	var tokenData map[string]interface{}
-	json.NewDecoder(tokenResp.Body).Decode(&tokenData)
+	if err := json.NewDecoder(tokenResp.Body).Decode(&tokenData); err != nil {
+		t.Fatalf("Failed to decode token response: %v", err)
+	}
 	accessToken := tokenData["access_token"].(string)
 
 	t.Run("Step 1: Verify userinfo works with valid token", func(t *testing.T) {