Don't run side-effects for pure-clojurescript (non-interop) -> chains
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduced logic is as follows:
(-> )(i.e. its first member) does not matchjs/*orjs/*, then evaluation (side-effects) will shortcircuited.(. ,,,),(.. ,,,),(doto ,,,), evaluation will never be shortcircuited, because those macros are interop-oriented.It's not perfect, but it seems to find a balance between shortcircuiting most pure clojurescript forms, and allow JS completions to still work for many cases.
In a future, logic may be refined by leveraging the cljs analyzer - we already do in cider-nrepl so it should be at hand.
Cheers - V