propagating errors

Author: karthikbhargavan

crypto/sha2-hacl.c

@@ -19,9 +19,9 @@ int hacl_sha256_update(struct shash_desc *desc, const u8 *data,
         st.block_state = sctx->state;
         st.buf = sctx->buf;
         st.total_len = sctx->count;
-        Hacl_Streaming_SHA2_update_256(&st, (u8 *)data, len);
+        uint8_t res = Hacl_Streaming_SHA2_update_256(&st, (u8 *)data, len);
         sctx->count = st.total_len;
-        return 0;
+        return res;
 }
 EXPORT_SYMBOL(hacl_sha256_update);
 
@@ -64,9 +64,9 @@ int hacl_sha512_update(struct shash_desc *desc, const u8 *data,
         st.block_state = sctx->state;
         st.buf = sctx->buf;
         st.total_len = sctx->count[0];
-        Hacl_Streaming_SHA2_update_512(&st, (u8 *)data, len);
+        uint8_t res = Hacl_Streaming_SHA2_update_512(&st, (u8 *)data, len);
         sctx->count[0] = st.total_len;
-        return 0;
+        return res;
 }
 EXPORT_SYMBOL(hacl_sha512_update);
 
@@ -92,12 +92,15 @@ int hacl_sha512_finup(struct shash_desc *desc, const u8 *data, unsigned int len,
         st.block_state = sctx->state;
         st.buf = sctx->buf;
         st.total_len = sctx->count[0];
-        Hacl_Streaming_SHA2_update_512(&st, (u8 *)data, len);
-        if (crypto_shash_digestsize(desc->tfm) == SHA384_DIGEST_SIZE)
-                Hacl_Streaming_SHA2_finish_384(&st, hash);
-        else
-                Hacl_Streaming_SHA2_finish_512(&st, hash);
-        return 0;
+        uint8_t res = Hacl_Streaming_SHA2_update_512(&st, (u8 *)data, len);
+	if (res == 0) {
+	        if (crypto_shash_digestsize(desc->tfm) == SHA384_DIGEST_SIZE)
+	                Hacl_Streaming_SHA2_finish_384(&st, hash);
+		else
+		        Hacl_Streaming_SHA2_finish_512(&st, hash);
+	        return 0;
+	} else
+	        return res;
 }
 EXPORT_SYMBOL(hacl_sha512_finup);